fix(hermes): register cliproxy as a proper provider - #2334
Conversation
The was empty, causing Hermes to fail with 'No inference provider configured' on every request. The section doesn't register providers for model routing. Changed to a proper cliproxy provider definition with base_url, api_key, and api_mode. This should fix the primary auth failure and allow deepseek-v4-flash to work without falling back to pro.
|
Warning Indent Zero is shutting down on August 7th. Please migrate over to Indent 2.0 to continue getting PR reviews.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Hermes configuration templates now define a ChangesCLIProxy provider configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| cliproxy: | ||
| base_url: https://cliproxy.shunkakinoki.com/v1 | ||
| api_key: __CLIPROXY_API_KEY__ | ||
| api_mode: chat_completions |
There was a problem hiding this comment.
Duplicate cliproxy definition — the same endpoint is still declared under custom_providers: at lines 329-333 of this file (and the equivalent block in config.tpl.yaml). Upstream hermes_cli/config.get_compatible_custom_providers reads both providers: and custom_providers: and dedupes them by (name, base_url, model), so today they collapse to a single entry — but this is a latent hazard: if either copy gets an edit (base_url, api_mode swap, models list, extra_headers, context_length, enabled: false), the two definitions silently diverge and only the copy the resolver hits first (providers:) wins. Pick a single source of truth — either drop the custom_providers: block below or revert to using it alone (which was already sufficient, see the misdiagnosis note on the commit message).
Problem
The Hermes config had
providers: {}which means no inference providers registered. Thecustom_providerssection at the bottom of the config doesn't register providers for model routing. Every request failed with:This caused every request to fall back from
deepseek-v4-flashtodeepseek-v4-pro, wasting tokens.Fix
Changed
providers: {}to a proper cliproxy provider definition:After merge
Re-hydrate config and restart gateway. deepseek-v4-flash should work as the primary model.
Summary by cubic
Registers cliproxy as an inference provider in Hermes so the default deepseek-v4-flash model works without falling back to pro. Fixes “No inference provider configured” errors and stops token waste.
Bug Fixes
providers: {}with a propercliproxyprovider (base_url,__CLIPROXY_API_KEY__,api_mode: chat_completions) in both Hermes config templates.Migration
__CLIPROXY_API_KEY__is set.Written for commit 94b2b51. Summary will update on new commits.