Skip to content

feat: add before-and-after - #2324

Merged
shunkakinoki merged 1 commit into
mainfrom
codex/add-before-and-after
Aug 9, 2026
Merged

feat: add before-and-after#2324
shunkakinoki merged 1 commit into
mainfrom
codex/add-before-and-after

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Adds the @vercel/before-and-after CLI, trusts its package scripts, and updates the dotagents submodule to the matching locked skill.

Validated with a frozen Bun install and before-and-after --help.


Summary by cubic

Add the @vercel/before-and-after CLI (v0.0.4) and trust its package scripts so it can run in our tooling. Update the dotagents submodule to the matching locked skill and refresh bun.lock.

Written for commit b802705. Summary will update on new commits.

Review in cubic

@indent-zero

indent-zero Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Indent Zero is shutting down on August 7th. Please migrate over to Indent 2.0 to continue getting PR reviews.

PR Summary

Adds Vercel's before-and-after visual-diff tooling to the dotfiles environment. Introduces the @vercel/before-and-after@0.0.4 CLI as an npm dependency and bumps the dotagents submodule so the corresponding agent skill is registered. The submodule bump is intended to enable the skill in SKILLS.txt/skills-lock.json, but the pinned SHA is unreachable on the remote (see reported issue).

  • Add @vercel/before-and-after@0.0.4 to dependencies and trustedDependencies in package.json (alphabetical placement preserved).
  • Regenerate bun.lock with the new package and its resolutions; incidentally reconciles t3@0.0.32 (already in main's package.json but missing from main's lockfile) and pulls in its transitive tree (@effect/*, @ff-labs/*, ioredis/ffi-rs families, etc.).
  • Bump dotagents submodule from fa405a0d… to 9589ed39a7f0dd49c4fd396bbe559a7d4f7bc9b1.

Issues

1 potential issue found:

  • The dotagents submodule is pinned to 9589ed39a7f0dd49c4fd396bbe559a7d4f7bc9b1, but that SHA does not exist in shunkakinoki/dotagents (git fetch returns not our ref); the codex/add-before-and-after-skill branch that actually adds the skill points to 9589ed3568017b7d7e422e783425c406946ef173. git submodule update --init will fail for anyone cloning and the before-and-after skill never actually lands, so re-pin the submodule to the reachable SHA before merging. → Autofix

CI Checks

Waiting for CI checks...


⚡ Autofix All Issues

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Chores

    • Updated internal project tooling to support improved before-and-after experiences.
    • Refreshed supporting configuration and development resources.
  • User Impact

    • No visible changes to existing product functionality.

Walkthrough

The PR advances the dotagents submodule reference and adds @vercel/before-and-after version 0.0.4 to package.json and its trusted dependency list.

Changes

Maintenance updates

Layer / File(s) Summary
Dependency and submodule configuration
dotagents, package.json
The dotagents submodule points to a newer commit. @vercel/before-and-after is added as a dependency and trusted dependency.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested labels: dependencies

Poem

A rabbit hops through agent trails,
While fresh packages fill the sails.
Trusted bits are tucked in tight,
The submodule points to newer light.
“Hop approved!” the rabbit sings.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: adding the before-and-after CLI.
Description check ✅ Passed The description accurately explains the CLI addition, trusted scripts, submodule update, and validation performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/add-before-and-after

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@dotagents`:
- Line 1: Revert the dotagents submodule gitlink to its previous reachable
commit, removing the pointer to 9589ed39a7f0dd49c4fd396bbe559a7d4f7bc9b1 until
that commit is available from the upstream submodule remote.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f1a6e75a-fccd-412d-9c7b-7a4a3088c27d

📥 Commits

Reviewing files that changed from the base of the PR and between 47d5335 and b802705.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • dotagents
  • package.json

Comment thread dotagents
@@ -1 +1 @@
Subproject commit fa405a0d3240cdc5b6df38b603d8bab6b1c3d583
Subproject commit 9589ed39a7f0dd49c4fd396bbe559a7d4f7bc9b1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

expected="9589ed39a7f0dd49c4fd396bbe559a7d4f7bc9b1"
actual="$(git ls-tree HEAD -- dotagents | awk '$4 == "dotagents" { print $3 }')"
test "$actual" = "$expected"

remote="$(git config -f .gitmodules --get submodule.dotagents.url)"
tmp="$(mktemp -d)"
trap 'rm -rf "$tmp"' EXIT

git clone --filter=blob:none --no-checkout "$remote" "$tmp/dotagents"
git -C "$tmp/dotagents" cat-file -e "$expected^{commit}"

old="$(git rev-parse HEAD^:dotagents 2>/dev/null || true)"
if [ -n "$old" ]; then
  git -C "$tmp/dotagents" diff --name-status "$old" "$expected"
fi

Repository: shunkakinoki/dotfiles

Length of output: 466


🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

printf 'HEAD dotagents gitlink:\n'
git ls-tree HEAD -- dotagents || true

printf '\nPrevious HEAD dotagents gitlink:\n'
git rev-parse --verify HEAD^:dotagents || true

printf '\nHEAD@{1} dotagents gitlink:\n'
git rev-parse --verify HEAD@{1}:dotagents || true

printf '\n.gitmodules dotagents entry:\n'
git config -f .gitmodules --get-regexp 'submodule\.dotagents\.' || true

printf '\nLocal refs/object around dotagents:\n'
git for-each-ref --format='%(refname) %(objectname) %(objecttype)' | rg 'dotagents|dotfiles|main|master' || true

printf '\nLocal object existence check:\n'
expected="9589ed39a7f0dd49c4fd396bbe559a7d4f7bc9b1"
git cat-file -e "$expected" && git cat-file -t "$expected" || true

Repository: shunkakinoki/dotfiles

Length of output: 901


Reject this submodule pointer until the target commit is reachable.

The configured dotagents submodule points to 9589ed39a7f0dd49c4fd396bbe559a7d4f7bc9b1, but that object is not available from the submodule remote. Revert the gitlink change until the intended commit is public in the upstream repository.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@dotagents` at line 1, Revert the dotagents submodule gitlink to its previous
reachable commit, removing the pointer to
9589ed39a7f0dd49c4fd396bbe559a7d4f7bc9b1 until that commit is available from the
upstream submodule remote.

@shunkakinoki
shunkakinoki merged commit c5df6a3 into main Aug 9, 2026
17 of 29 checks passed
@shunkakinoki
shunkakinoki deleted the codex/add-before-and-after branch August 9, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant