Skip to content

fix(dotagents): consume latest Skills SDK - #2284

Merged
shunkakinoki merged 1 commit into
mainfrom
codex/use-latest-dotagents-skills-sdk
Aug 6, 2026
Merged

fix(dotagents): consume latest Skills SDK#2284
shunkakinoki merged 1 commit into
mainfrom
codex/use-latest-dotagents-skills-sdk

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Aug 6, 2026

Copy link
Copy Markdown
Owner

What changed

Update the dotagents submodule to the source fix in shunkakinoki/dotagents#186.

This makes the Skills SDK install work from the upstream ~/dotfiles checkout as well as directly inside dotagents/, and uses the current stable SDK through the project-local dependency/lockfile.

Verification

  • make skills-install from ~/dotfiles
  • make -C dotagents skills-install
  • make dotagents-sync

Summary by cubic

Update dotagents submodule to pick up the latest Skills SDK fix. Installs now work from ~/dotfiles and inside dotagents/, and the project uses the current stable SDK via the local lockfile.

  • Migration
    • Run make dotagents-sync, then make skills-install (or make -C dotagents skills-install).

Written for commit 4038cbc. Summary will update on new commits.

Review in cubic

@indent-zero

indent-zero Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor
PR Summary

Bumps the dotagents submodule to pick up the upstream Skills SDK install fix (shunkakinoki/dotagents#186), which upgrades skills from ^1.5.20 to ^1.5.22, switches to the project-local ./node_modules/.bin/skills CLI, and computes an absolute SKILLS_PROJECT_DIR so make skills-install works from both ~/dotfiles and dotagents/. Net effect: consumers can install the current stable Skills SDK reliably regardless of invocation cwd.

  • Advances the dotagents submodule pointer from f8b3e29 to fa405a0, bringing in three upstream commits (Matt Pocock skills v1.2 bump, SDK lockfile refresh, and upstream-checkout invocation fix).

Issues

1 potential issue found:

  • Submodule pointer fa405a0d is not on dotagents/main — it only lives on the still-open upstream branch codex/use-latest-skills-sdk (PR fix(skills): use current SDK from upstream dotfiles dotagents#186 is not merged). Trigger: once that PR is squash/rebase-merged and the branch is deleted (or force-pushed), the SHA becomes unreachable and git clone --recurse-submodules on dotfiles will fail with "reference is not a tree". Wait for chore(deps): lock file maintenance #186 to merge, then bump this submodule to the resulting commit on dotagents/main. → Autofix

CI Checks

Waiting for CI checks...


⚡ Autofix All Issues

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e0c6d51-c9d3-44db-a790-10f6e076038d

📥 Commits

Reviewing files that changed from the base of the PR and between 230f3d6 and 4038cbc.

📒 Files selected for processing (1)
  • dotagents

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the bundled agent configuration to the latest version.

Walkthrough

The dotagents submodule pointer changed from commit f8b3e294d40011eb04b6dc88cc9e4e8d2231dc12 to fa405a0d3240cdc5b6df38b603d8bab6b1c3d583.

Changes

dotagents submodule update

Layer / File(s) Summary
Update submodule pointer
dotagents
The submodule reference now points to commit fa405a0d3240cdc5b6df38b603d8bab6b1c3d583.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A rabbit checks the pointer bright,
From one commit to new delight.
dotagents hops ahead,
Its newer path is read.
One tiny change, reviewed just right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the dotagents submodule update and its purpose of consuming the latest Skills SDK.
Description check ✅ Passed The description directly explains the dotagents update, the Skills SDK installation fix, and the verification performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/use-latest-dotagents-skills-sdk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@shunkakinoki
shunkakinoki merged commit 29f6555 into main Aug 6, 2026
36 of 37 checks passed
@shunkakinoki
shunkakinoki deleted the codex/use-latest-dotagents-skills-sdk branch August 6, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant