chore(deps): update noctalia-shell digest to 10b2007 - #1986
Conversation
Signed-off-by:
|
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the pinned commit for the noctalia-shell dependency in both flake.nix and flake.lock to 10b2007088ba2e1b94e96b01aec4631bc6266d1a. There are no review comments to address, and I have no feedback to provide on these straightforward dependency updates.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis change updates the pinned commit hash for the noctalia-shell flake input in flake.nix, repointing it to a newer revision. ChangesFlake Input Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![indent-zero[bot]](https://avatars.githubusercontent.com/in/1426746?s=60&v=4){kind=small}
| # but renovate can still auto-bump this input: treat bumps as breaking and | ||
| # rebuild matic/viper on-device before merging (can't be validated in darwin CI). | ||
| url = "github:noctalia-dev/noctalia-shell/0d2c346e3b9c1e23efd06a5f70d9823f0db1c482"; | ||
| url = "github:noctalia-dev/noctalia-shell/10b2007088ba2e1b94e96b01aec4631bc6266d1a"; |
There was a problem hiding this comment.
Process reminder from the pinned comment above: "treat bumps as breaking and rebuild matic/viper on-device before merging (can't be validated in darwin CI)." This Renovate PR advances the pin by ~24 upstream commits, including non-trivial changes (desktop-widget namespacing #3223, hyprland floating-window raise #3263, panel placement with multiple bars on the same edge, tooltip anchor fix #3147, network VPN/link separation with async NM calls, pipewire accel rework). No TOML schema migration commits appear in the range, but please confirm programs.noctalia still starts cleanly on matic/viper before merging.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
flake.nix (1)
73-73: 🗄️ Data Integrity & Integration | 🔵 TrivialTreat this bump as breaking
inputs.noctalia-shell.homeModules.defaultis imported directly here, and the new upstream revision includes broad changes across config, schema, network, and UI. Check the module options and any config you rely on before merging.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@flake.nix` at line 73, The noctalia-shell input revision bump should be handled as a breaking change because flake.nix imports inputs.noctalia-shell.homeModules.default directly. Review the upstream module changes against the configuration used here, verify any referenced options or schemas still exist and behave the same, and update the consuming config if needed before accepting the new revision.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@flake.nix`:
- Line 73: The noctalia-shell input revision bump should be handled as a
breaking change because flake.nix imports
inputs.noctalia-shell.homeModules.default directly. Review the upstream module
changes against the configuration used here, verify any referenced options or
schemas still exist and behave the same, and update the consuming config if
needed before accepting the new revision.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 99cfc16e-6d78-42a2-9da9-824f1ab0969c
⛔ Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
flake.nix
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="flake.nix">
<violation number="1" location="flake.nix:73">
P2: This pin update spans ~24 upstream commits with non-trivial changes (desktop-widget namespacing, hyprland floating-window raise, panel placement with multiple bars, tooltip anchor fix, network VPN/link separation with async NM calls, pipewire accel rework). Per the inline comment on lines 71–72, this bump should be treated as breaking and validated on matic/viper on-device before merging, since darwin CI cannot exercise this path. Please confirm `programs.noctalia` still starts cleanly on those hosts before landing.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| # but renovate can still auto-bump this input: treat bumps as breaking and | ||
| # rebuild matic/viper on-device before merging (can't be validated in darwin CI). | ||
| url = "github:noctalia-dev/noctalia-shell/0d2c346e3b9c1e23efd06a5f70d9823f0db1c482"; | ||
| url = "github:noctalia-dev/noctalia-shell/10b2007088ba2e1b94e96b01aec4631bc6266d1a"; |
There was a problem hiding this comment.
P2: This pin update spans ~24 upstream commits with non-trivial changes (desktop-widget namespacing, hyprland floating-window raise, panel placement with multiple bars, tooltip anchor fix, network VPN/link separation with async NM calls, pipewire accel rework). Per the inline comment on lines 71–72, this bump should be treated as breaking and validated on matic/viper on-device before merging, since darwin CI cannot exercise this path. Please confirm programs.noctalia still starts cleanly on those hosts before landing.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At flake.nix, line 73:
<comment>This pin update spans ~24 upstream commits with non-trivial changes (desktop-widget namespacing, hyprland floating-window raise, panel placement with multiple bars, tooltip anchor fix, network VPN/link separation with async NM calls, pipewire accel rework). Per the inline comment on lines 71–72, this bump should be treated as breaking and validated on matic/viper on-device before merging, since darwin CI cannot exercise this path. Please confirm `programs.noctalia` still starts cleanly on those hosts before landing.</comment>
<file context>
@@ -70,7 +70,7 @@
# but renovate can still auto-bump this input: treat bumps as breaking and
# rebuild matic/viper on-device before merging (can't be validated in darwin CI).
- url = "github:noctalia-dev/noctalia-shell/0d2c346e3b9c1e23efd06a5f70d9823f0db1c482";
+ url = "github:noctalia-dev/noctalia-shell/10b2007088ba2e1b94e96b01aec4631bc6266d1a";
inputs.nixpkgs.follows = "nixpkgs";
};
</file context>
2 participants
This PR contains the following updates:
0d2c346→10b2007Configuration
📅 Schedule: (in timezone UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.
Summary by cubic
Updates the pinned
noctalia-shellinput to the latest revision to pick up recent fixes. Refreshesflake.nixandflake.lock.Dependencies
noctalia-shelland updated lock data.Migration
maticandviperon-device before merging (darwin CI cannot validate).Written for commit 8a9fd2c. Summary will update on new commits.