chore(deps): update noctalia-shell digest to 6e7aa3b - #1974
Conversation
Signed-off-by:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pinned commit hash for the ChangesFlake Input Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the pinned commit for noctalia-shell in flake.nix and updates flake.lock accordingly. However, this update violates the pinning constraint documented in the code comments, as the new revision drops the noctalia-qs input and introduces upstream restructuring that breaks the programs.noctalia-shell option. It is recommended to close this pull request and configure Renovate to ignore future updates for noctalia-shell.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # Pinned before upstream dropped the noctalia-qs input and restructured | ||
| # the home-manager module (breaks programs.noctalia-shell option). | ||
| url = "github:noctalia-dev/noctalia-shell/b16dc50250af05d5048ac454dbf4e898d1adcac0"; | ||
| url = "github:noctalia-dev/noctalia-shell/6e7aa3b4daaf13f3cd7c622b248efaba5c1c1eb3"; |
There was a problem hiding this comment.
This automated update to 6e7aa3b4daaf13f3cd7c622b248efaba5c1c1eb3 violates the pinning constraint described in the comment on lines 68-69. As shown in the flake.lock diff, this revision indeed drops the noctalia-qs input and contains the upstream restructuring that breaks the programs.noctalia-shell option.\n\nTo prevent breaking the configuration, this PR should be closed, and Renovate should be configured to ignore updates for noctalia-shell.
url = "github:noctalia-dev/noctalia-shell/b16dc50250af05d5048ac454dbf4e898d1adcac0";
![indent-zero[bot]](https://avatars.githubusercontent.com/in/1426746?s=60&v=4){kind=small}
| # Pinned before upstream dropped the noctalia-qs input and restructured | ||
| # the home-manager module (breaks programs.noctalia-shell option). | ||
| url = "github:noctalia-dev/noctalia-shell/b16dc50250af05d5048ac454dbf4e898d1adcac0"; | ||
| url = "github:noctalia-dev/noctalia-shell/6e7aa3b4daaf13f3cd7c622b248efaba5c1c1eb3"; |
There was a problem hiding this comment.
Bump violates the intentional pin. The comment two lines above says: "Pinned before upstream dropped the noctalia-qs input and restructured the home-manager module (breaks programs.noctalia-shell option)." The lock diff confirms noctalia-qs is gone, and upstream nix/home-module.nix at 6e7aa3b declares options.programs.noctalia (no -shell suffix). config/noctalia/default.nix:79 still sets programs.noctalia-shell = { … }, so home-manager evaluation will fail with The option \programs.noctalia-shell' does not existfor every desktop host. Either keep the pin (recommended, plus add a RenovatepackageRules` entry to stop reopening this PR) or land a full migration PR (rename the option, migrate settings to TOML v5, rename the binary references — see the other issues on this PR).
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="flake.nix">
<violation number="1" location="flake.nix:70">
P0: This revision update contradicts the pinning comment immediately above (lines 68-69), which explicitly states the input is pinned to avoid a breaking upstream change. The `flake.lock` diff confirms the new revision `6e7aa3b` drops the `noctalia-qs` input — the exact restructuring the pin was meant to prevent. Updating to this revision will break the `programs.noctalia-shell` home-manager option. The previous pinned revision (`b16dc50`) should be kept, and Renovate should be configured to ignore updates for this input.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| # Pinned before upstream dropped the noctalia-qs input and restructured | ||
| # the home-manager module (breaks programs.noctalia-shell option). | ||
| url = "github:noctalia-dev/noctalia-shell/b16dc50250af05d5048ac454dbf4e898d1adcac0"; | ||
| url = "github:noctalia-dev/noctalia-shell/6e7aa3b4daaf13f3cd7c622b248efaba5c1c1eb3"; |
There was a problem hiding this comment.
P0: This revision update contradicts the pinning comment immediately above (lines 68-69), which explicitly states the input is pinned to avoid a breaking upstream change. The flake.lock diff confirms the new revision 6e7aa3b drops the noctalia-qs input — the exact restructuring the pin was meant to prevent. Updating to this revision will break the programs.noctalia-shell home-manager option. The previous pinned revision (b16dc50) should be kept, and Renovate should be configured to ignore updates for this input.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At flake.nix, line 70:
<comment>This revision update contradicts the pinning comment immediately above (lines 68-69), which explicitly states the input is pinned to avoid a breaking upstream change. The `flake.lock` diff confirms the new revision `6e7aa3b` drops the `noctalia-qs` input — the exact restructuring the pin was meant to prevent. Updating to this revision will break the `programs.noctalia-shell` home-manager option. The previous pinned revision (`b16dc50`) should be kept, and Renovate should be configured to ignore updates for this input.</comment>
<file context>
@@ -67,7 +67,7 @@
# Pinned before upstream dropped the noctalia-qs input and restructured
# the home-manager module (breaks programs.noctalia-shell option).
- url = "github:noctalia-dev/noctalia-shell/b16dc50250af05d5048ac454dbf4e898d1adcac0";
+ url = "github:noctalia-dev/noctalia-shell/6e7aa3b4daaf13f3cd7c622b248efaba5c1c1eb3";
inputs.nixpkgs.follows = "nixpkgs";
};
</file context>
| url = "github:noctalia-dev/noctalia-shell/6e7aa3b4daaf13f3cd7c622b248efaba5c1c1eb3"; | |
| url = "github:noctalia-dev/noctalia-shell/b16dc50250af05d5048ac454dbf4e898d1adcac0"; |
This PR contains the following updates:
b16dc50→6e7aa3bConfiguration
📅 Schedule: (in timezone UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.
Summary by cubic
Updates pinned
noctalia-shellto commit6e7aa3band cleans up the Nix flake inputs after upstream dropped thenoctalia-qsdependency. No behavior changes; just dependency housekeeping.noctalia-shellfromb16dc50to6e7aa3binflake.nixandflake.lock.noctalia-qsand the relatedsystems_4entry fromflake.lock.treefmt-nixreferences by consolidating totreefmt-nix_4.Written for commit 6234788. Summary will update on new commits.