fix(nix): fix dolt launchd ProgramArguments type error

[shunkakinoki]

Summary

• writeShellScript returns a derivation that nix-darwin's ProgramArguments type checker rejects as non-string
• Replace with pkgs.replaceVars + bash invocation pattern used by all other launchd agents in this repo
• Fixes nix-darwin build failure: A definition for option 'home-manager.users.shunkakinoki.launchd.agents.dolt.config.ProgramArguments."[definition 1-entry 1]"' is not of type 'string'

Test plan

• Nix CI (nix-darwin job) passes
• Shell inline check passes (no writeShellScript with inline content)

---

Summary by cubic

Fixes a nix-darwin build failure for the dolt launchd agent by switching to a bash + pkgs.replaceVars script so ProgramArguments are valid strings and the service starts reliably on macOS. Also formats drifted files with treefmt (nixfmt, shfmt).

• Bug Fixes
  • Use a pkgs.replaceVars script invoked via ${pkgs.bash}/bin/bash in ProgramArguments.
  • Update Service.ExecStart to use the same bash invocation.

^{Written for commit da53eaf. Summary will update on new commits.}

[mesa-dot-dev]

You do not have enough credits to review this pull request. Please purchase more credits to continue.

[coderabbitai]

📝 Walkthrough

Walkthrough

This change refactors the dolt service configuration in Home Manager by switching from a wrapped script approach to directly using pkgs.replaceVars on an external shell script file. The launchd and systemd service invocations are updated to explicitly call bash with the script path.

Changes

Cohort / File(s)	Summary
Dolt Service Script Refactoring home-manager/services/dolt/default.nix	Replaced writeShellScript wrapper with direct pkgs.replaceVars ./start.sh invocation; updated launchd ProgramArguments to invoke bash explicitly with script path; updated systemd ExecStart to run bash ${startScript} instead of executing script directly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• fix: openclaw thinking #1485: Modifies the same dolt service configuration with similar adjustments to start script production and launchd/systemd invocation patterns.
• fix(ci): unbreak shell-inline-check on main #1487: Updates the dolt service startup by replacing inline Nix-written scripts with external ./start.sh using pkgs.replaceVars and updating shell invocation across init systems.

Poem

🐰 A script once wrapped in Nix's gentle hands,
Now freed to roam in .sh across the lands,
With bash invoked by name, both loud and clear,
The dolt service hops on without a fear! 🌿

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing a nix-darwin type error with dolt launchd ProgramArguments by refactoring the script construction approach.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The pull request description clearly describes the changeset: replacing writeShellScript with pkgs.replaceVars to fix a nix-darwin type error for ProgramArguments.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bridge-cse_01EDgELPMMxETUCGMvtqrQLv

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[mesa-dot-dev]

Mesa Description

TL;DR

Fixes a nix-darwin build failure for the dolt launchd agent by switching to a bash + pkgs.replaceVars script, ensuring ProgramArguments are valid strings and the service starts reliably on macOS.

What changed?

• home-manager/services/dolt/default.nix: The method for generating the Dolt service's startScript has been simplified by directly using pkgs.replaceVars. Consequently, both launchd and systemd service configurations were updated to explicitly execute this script using bash for consistent behavior.

^{Description generated by Mesa. Update settings}

[cubic-dev-ai]

No issues found across 1 file

[gemini-code-assist]

Code Review

This pull request refactors the startScript definition in the Dolt home-manager service to use pkgs.replaceVars directly and updates the service configurations to explicitly invoke bash for both Darwin and Linux environments. A review comment suggests quoting the script path in the systemd ExecStart command to improve robustness and follow shell best practices.

[gemini-code-assist]

While Nix store paths do not contain spaces, it is generally safer and more robust to quote the script path in ExecStart to prevent potential issues if the path were ever to change or if this pattern is copied elsewhere.

      ExecStart = "${pkgs.bash}/bin/bash '${startScript}'";