fix: openclaw thinking - #1485
Conversation
Global default: low Opus agents: high (deep reasoning) Sonnet agents: medium GLM agents: off (cheap, no thinking overhead) GPT/Gemini/Minimax: low (inherited from default) Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Empty string caused memory-core to not be found as the slot plugin, which meant no public artifacts were exported, breaking the wiki bridge pipeline entirely (0 entries since April 12). Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Bridge mode's publicArtifacts capability chain wasn't resolving at runtime, resulting in 0 artifacts exported and no wiki entries since April 12. Unsafe-local mode reads memory files directly by path, bypassing the broken plugin slot capability chain. Immediately imported 252 source pages on restart. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Add a dedicated dotfiles Dolt service with systemd on kyber and launchd on galactica. Wire the Makefile restart targets into the platform service bundles and ignore the updated local beads runtime layout. Keep the current OpenClaw template routing changes in sync so local hydration can pick up the committed config updates. Co-authored-by: Codex <noreply@openai.com>
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR introduces a new Dolt SQL server Home Manager service for macOS and Linux with conditional startup and directory migration logic, updates OpenClaw configuration with revised default thinking levels and agent-specific overrides, adds new WhatsApp bindings, restructures memory plugin settings, and adds supporting Makefile targets and package dependencies. Changes
Sequence Diagram(s)sequenceDiagram
participant Script as StartScript
participant FS as Filesystem
participant Dolt as Dolt Process
Script->>FS: Check .beads dir exists
FS-->>Script: Create if missing
Script->>FS: Check if dolt is directory
alt dolt dir exists and df dir missing
Script->>FS: Migrate dolt/ to df/
FS-->>Script: Migration complete
else df dir already exists
Script->>Script: Fail (conflict detected)
end
Script->>FS: Create dolt symlink → df
FS-->>Script: Symlink established
Script->>Dolt: Exec dolt sql-server<br/>127.0.0.1:3307<br/>--data-dir .beads
Dolt-->>Script: Server running
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mesa DescriptionTL;DRThis PR primarily focuses on fixing and improving the OpenClaw system, including adjustments to its thinking process, memory management, and service configurations. It also introduces the What changed?
Description generated by Mesa. Update settings |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a Dolt SQL server service for managing data in the .beads directory, providing automation for macOS and Linux. It also modifies the OpenClaw configuration by lowering global thinking defaults, adding specific agent settings, and updating the wiki memory module to use local vault access. Feedback points out that several new entries in the package and service lists are not alphabetically ordered. Furthermore, the Dolt startup script contains a logic issue where symlinking within the data directory could lead to database locking errors and redundant loading attempts.
| cmatrix | ||
| cloudflared |
There was a problem hiding this comment.
The package cmatrix is out of alphabetical order. It should be placed after cloudflared to maintain consistency with the rest of the file.
cloudflared
cmatrix
| dolt = ./dolt; | ||
| docker = import ./docker { inherit lib pkgs; }; | ||
| dockerPostgres = import ./docker-postgres { inherit pkgs; }; |
There was a problem hiding this comment.
The dolt service import is out of alphabetical order. It should follow docker and dockerPostgres.
docker = import ./docker { inherit lib pkgs; };
dockerPostgres = import ./docker-postgres { inherit pkgs; };
dolt = ./dolt;
| dolt | ||
| docker | ||
| dockerPostgres |
There was a problem hiding this comment.
The dolt service is out of alphabetical order in the list. It should follow docker and dockerPostgres.
docker
dockerPostgres
dolt
| if [ -d "${beadsDir}/df" ]; then | ||
| ln -sfn df "${beadsDir}/dolt" | ||
| fi | ||
|
|
||
| exec "${pkgs.dolt}/bin/dolt" sql-server \ | ||
| -H 127.0.0.1 \ | ||
| -P 3307 \ | ||
| --data-dir "${beadsDir}" \ | ||
| --loglevel info |
There was a problem hiding this comment.
Creating a symlink named dolt pointing to df inside the same directory used as --data-dir for Dolt will cause the sql-server to attempt to load the same database twice (once as df and once as dolt). Since they share the same underlying data files, one of them will fail to acquire a lock, resulting in noisy error logs. Furthermore, pointing --data-dir to ${beadsDir} (which contains non-database files and directories like backup/ or interactions.jsonl as seen in the .gitignore) will cause Dolt to attempt to load those as databases as well. It is recommended to use a dedicated subdirectory for databases or move the compatibility symlink outside of the directory scanned by Dolt.
1 participant
Summary by cubic
Set per-agent thinking defaults by model tier and fix OpenClaw memory wiring to restore wiki ingestion and artifact exports. Adds a
doltSQL service with restart targets and a small package update.Bug Fixes
thinkingDefault: global low; Opus high; Sonnet medium; GLM off; others inherit low.plugins.slots.memorytomemory-coreto resume public artifact exports.memory-wikifrombridgetounsafe-localto read workspace files directly and unblock wiki imports.New Features
doltSQL server (launchd on galactica, systemd on kyber) with Makefile targets:launchctl-dolt,systemctl-dolt.cmatrixto home packages.Written for commit 5735093. Summary will update on new commits.