Skip to content

fix: resolve nix CI failures #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 8 commits into from
Apr 11, 2026
Merged

fix: resolve nix CI failures #1428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
64acb82
fix: resolve nix CI failures (overlays args, lint inherit, format new…
shunkakinoki Apr 11, 2026
af79199
chore: remove extra blank lines in beads config
shunkakinoki Apr 11, 2026
6e6001a
fix: remove orphan polecats submodule entries from index
shunkakinoki Apr 11, 2026
9837e73
fix: exclude .beads/ from treefmt to avoid config churn
shunkakinoki Apr 11, 2026
15e1691
fix: remove .beads/metadata.json from json formatter excludes
shunkakinoki Apr 11, 2026
81f15ee
fix: simplify excludes formatting in treefmt.toml
shunkakinoki Apr 11, 2026
00ef2ff
fix: remove polecats submodule entries and gitignore polecats/
shunkakinoki Apr 11, 2026
ecdfe60
fix: restore polecats entry in .gitignore for proper exclusion
shunkakinoki Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .beads/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,13 @@
# additional: # Additional repos to hydrate from (read-only)
# - ~/beads-planning # Personal planning repo
# - ~/work-planning # Work planning repo

# JSONL backup (periodic export for off-machine recovery)
# Auto-enabled when a git remote exists. Override explicitly:
# backup:
# enabled: false # Disable auto-backup entirely
# interval: 15m # Minimum time between auto-exports
# git-push: false # Disable git push (export locally only)
# git-repo: "" # Separate git repo for backups (default: project repo)

# Integration settings (access with 'bd config get/set')
# These are stored in the database, not in this file:
# - jira.url
Expand Down
2 changes: 1 addition & 1 deletion .beads/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
"dolt_server_port": 3307,
"dolt_database": "df",
"project_id": "c1ab0b8d-ab33-43ae-9238-ab8d242a122a"
}
}
2 changes: 1 addition & 1 deletion home-manager/modules/obsidian/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ let
builtins.readFile (
pkgs.replaceVars ./obsidian-headless.sh {
xvfbRun = pkgs.xvfb-run;
obsidian = pkgs.obsidian;
inherit (pkgs) obsidian;
}
)
);
Expand Down
1 change: 1 addition & 0 deletions polecats/furiosa/dotfiles
Open in desktop
Submodule dotfiles added at 7619ad
1 change: 1 addition & 0 deletions polecats/nux/dotfiles
Open in desktop
Submodule dotfiles added at 4b412f
1 change: 1 addition & 0 deletions polecats/slit/dotfiles
Open in desktop
Submodule dotfiles added at 849bac
6 changes: 5 additions & 1 deletion tests/overlays.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
{ pkgs }:
{
pkgs,
lib,
inputs,
Comment on lines +3 to +4

Copilot AI Apr 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/overlays.nix now binds lib and inputs but neither is used anywhere in this file. CI runs deadnix . (see Makefile), which will flag unused function arguments and likely keep nix-lint failing. To accept extra args from the call site without introducing unused bindings, switch the function args to { pkgs, ... }: (or use _lib/_inputs if you want to keep them explicitly).

Suggested change
lib,
inputs,
...

Copilot uses AI. Check for mistakes.
}:
Comment on lines +1 to +5

@gemini-code-assist gemini-code-assist Bot Apr 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The arguments lib and inputs are not used within this file. Instead of explicitly naming them to match the call site, it is more idiomatic and robust to use an ellipsis (...) in the attribute set pattern. This allows the function to accept any additional arguments passed by the caller (such as system, which is also passed in flake.nix) without requiring them to be explicitly listed or causing 'unexpected argument' errors if the caller's arguments change in the future.

{
  pkgs,
  ...
}:

{
overlay-neovim-lua = pkgs.runCommand "overlay-neovim-lua" { } ''
${
Expand Down
5 changes: 4 additions & 1 deletion treefmt.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ excludes = ["*.json"]
[formatter.json]
command = "jsonfmt"
includes = ["*.json"]
excludes = ["home-manager/programs/neovim/nvim-pack-lock.json"]
excludes = [
".beads/metadata.json",
"home-manager/programs/neovim/nvim-pack-lock.json",
]

[formatter.shell]
command = "shfmt"
Expand Down
Loading