fix: resolve nix CI failures - #1428
Conversation
…line) - tests/overlays.nix: accept `lib` and `inputs` args to match call site - home-manager/modules/obsidian/default.nix: use `inherit` instead of assignment - .beads/metadata.json: add trailing newline for formatter - treefmt.toml: exclude .beads/metadata.json from json formatter
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
📝 WalkthroughWalkthroughThis PR applies housekeeping updates across configuration, build, and module files: whitespace cleanup in YAML, trailing newline additions in JSON, submodule commit pointer updates, Nix syntax modernization, function signature expansion, and formatter configuration adjustments. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mesa DescriptionTL;DRResolved Nix CI failures by updating Nix configurations and formatting rules. What changed?
Description generated by Mesa. Update settings |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request includes configuration cleanups in .beads, updates to dotfile submodules, and Nix refactoring in the Obsidian module. It also modifies treefmt.toml and the function signature in tests/overlays.nix. A review comment suggests using an ellipsis in the tests/overlays.nix function signature to handle unused arguments more idiomatically.
| { | ||
| pkgs, | ||
| lib, | ||
| inputs, | ||
| }: |
There was a problem hiding this comment.
The arguments lib and inputs are not used within this file. Instead of explicitly naming them to match the call site, it is more idiomatic and robust to use an ellipsis (...) in the attribute set pattern. This allows the function to accept any additional arguments passed by the caller (such as system, which is also passed in flake.nix) without requiring them to be explicitly listed or causing 'unexpected argument' errors if the caller's arguments change in the future.
{
pkgs,
...
}:
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
polecats/slit/dotfiles (1)
15-17: Use literal grep matching for model IDs in tests.These assertions use regex-mode
grepto match model IDs containing., which are regex metacharacters. While unlikely to cause false positives in practice, usegrep -Ffor literal matching to ensure exact string matches and improve test robustness.Affects:
spec/fish/_coxel_function_test.fish(lines 10, 23),spec/fish/_coxelh_function_test.fish(line 13),spec/fish/_pixel_function_test.fish(lines 10, 19),spec/fish/_pixelh_function_test.fish(line 13),spec/fish/_ocxel_function_test.fish(lines 10, 21),spec/fish/_ocxelh_function_test.fish(line 14).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@polecats/slit/dotfiles` around lines 15 - 17, The tests that assert the substituted Qwen model currently use grep without fixed-string mode which treats dots as regex metacharacters; update the grep invocations in the test cases (e.g., the `@test` "no args uses substituted Qwen model" assertions that call grep -c "qwen3.5-0.8b-optiq" $log1) to use grep -F (or grep --fixed-strings) so the model ID is matched literally; apply the same change to the other affected test assertions mentioned in the review (the corresponding `@test` lines across the _coxel*, _coxelh*, _pixel*, _pixelh*, _ocxel*, and _ocxelh* function tests).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@polecats/slit/dotfiles`:
- Around line 15-17: The tests that assert the substituted Qwen model currently
use grep without fixed-string mode which treats dots as regex metacharacters;
update the grep invocations in the test cases (e.g., the `@test` "no args uses
substituted Qwen model" assertions that call grep -c "qwen3.5-0.8b-optiq" $log1)
to use grep -F (or grep --fixed-strings) so the model ID is matched literally;
apply the same change to the other affected test assertions mentioned in the
review (the corresponding `@test` lines across the _coxel*, _coxelh*, _pixel*,
_pixelh*, _ocxel*, and _ocxelh* function tests).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d5aa4022-bbac-45df-ac9b-56bd5f0ae58e
📒 Files selected for processing (8)
.beads/config.yaml.beads/metadata.jsonhome-manager/modules/obsidian/default.nixpolecats/furiosa/dotfilespolecats/nux/dotfilespolecats/slit/dotfilestests/overlays.nixtreefmt.toml
💤 Files with no reviewable changes (1)
- .beads/config.yaml
There was a problem hiding this comment.
Pull request overview
This PR aims to fix Nix CI failures by aligning test overlay function arguments with their call sites, addressing Nix lint/style warnings, and adjusting formatting configuration for .beads metadata/config files.
Changes:
- Update
tests/overlays.nixto accept additional arguments (lib,inputs) to match its import call site. - Resolve a nix-lint warning in the Obsidian Home Manager module by switching to
inherit (pkgs) obsidian. - Formatting-related cleanup: add newline to
.beads/metadata.json, remove blank lines in.beads/config.yaml, and exclude.beads/metadata.jsonfrom the JSON formatter intreefmt.toml.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
treefmt.toml |
Excludes .beads/metadata.json from jsonfmt to avoid formatter conflicts. |
tests/overlays.nix |
Adjusts overlay test import interface to match tests/default.nix call site. |
home-manager/modules/obsidian/default.nix |
Uses inherit (pkgs) obsidian in replaceVars attrset to satisfy nix-lint. |
.beads/metadata.json |
Adds trailing newline for formatting compliance. |
.beads/config.yaml |
Removes extra blank lines for formatter cleanliness. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| lib, | ||
| inputs, |
There was a problem hiding this comment.
tests/overlays.nix now binds lib and inputs but neither is used anywhere in this file. CI runs deadnix . (see Makefile), which will flag unused function arguments and likely keep nix-lint failing. To accept extra args from the call site without introducing unused bindings, switch the function args to { pkgs, ... }: (or use _lib/_inputs if you want to keep them explicitly).
| lib, | |
| inputs, | |
| ... |
Summary
tests/overlays.nix: acceptlibandinputsargs to match call site intests/default.nix:16(fixed nix-test and nix-flake)home-manager/modules/obsidian/default.nix:24: useinherit (pkgs) obsidianinstead of assignment (fixed nix-lint W04).beads/metadata.json: add trailing newline (fixed nix-format)treefmt.toml: exclude.beads/metadata.jsonfrom json formatter.beads/config.yaml: remove extra blank lines (formatter cleanup)Test plan
Summary by cubic
Fix Nix CI by aligning test overlay args, fixing a lint warning, stabilizing formatter config, and cleaning up Git ignores/submodules.
nix flake,nix test,nix-format, andnix-lintnow pass.tests/overlays.nix: acceptlibandinputsto match the test call site.home-manager/modules/obsidian/default.nix: useinherit (pkgs) obsidianto satisfy lint W04..beads/*viatreefmt, add a trailing newline to.beads/metadata.json, and trim.beads/config.yaml.polecatssubmodule entries and ensurecrew,polecats, andrefineryare ignored in.gitignore.Written for commit ecdfe60. Summary will update on new commits.