Skip to content

fix(hyprland): fix Slack and Telegram keybindings #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 1 commit into from
Mar 30, 2026
Merged

fix(hyprland): fix Slack and Telegram keybindings #1293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/hyprland/hyprland.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,9 @@ layerrule = ignore_alpha 0.3, match:namespace ^(rofi)$
# App Launch Hotkeys
# =============================================================================
bind = $mod, T, exec, ghostty
bind = ALT SHIFT, T, exec, telegram-desktop
bind = $mod SHIFT, T, exec, Telegram

@gemini-code-assist gemini-code-assist Bot Mar 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with how other applications like 1Password (line 233) and Signal (line 234) are launched, consider using gtk-launch. This is generally more robust as it uses the application's .desktop file instead of relying on an executable in the PATH.

The binary name Telegram is also unusual; the executable is typically telegram-desktop. Using gtk-launch with the correct desktop file name (e.g., telegramdesktop) would resolve this ambiguity.

bind = $mod SHIFT, T, exec, gtk-launch telegramdesktop

Copilot AI Mar 30, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telegram is likely not the executable provided by this repo’s installed package set. home-manager/packages/default.nix includes telegram-desktop, and this file previously used telegram-desktop; switching to Telegram may make the keybinding a no-op on fresh setups. Consider using the actual installed binary (telegram-desktop) or a stable desktop entry via gtk-launch if that’s the intended target.

Suggested change
bind = $mod SHIFT, T, exec, Telegram
bind = $mod SHIFT, T, exec, telegram-desktop

Copilot uses AI. Check for mistakes.
bind = $mod, G, exec, hyprctl clients -j | grep -q '"class": "google-chrome"' && hyprctl dispatch focuswindow class:google-chrome || google-chrome-stable
bind = $mod, S, exec, hyprctl clients -j | grep -q '"class": "Slack"' && hyprctl dispatch focuswindow class:Slack || slack
bind = $mod, S, exec, slack

@gemini-code-assist gemini-code-assist Bot Mar 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other application launchers in this file (e.g., lines 233 and 234), consider using gtk-launch to start Slack. This would make the launch method uniform across your application bindings.

bind = $mod, S, exec, gtk-launch slack

Copilot AI Mar 30, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says Super+S should “always open a new Slack window”, but this binding now just runs slack without any flag/command to force a new window. If Slack reuses the existing instance (common for Electron apps), this won’t meet the stated behavior; consider invoking Slack with an explicit new-window option or an alternative command that guarantees a new window.

Copilot uses AI. Check for mistakes.

Copilot AI Mar 30, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes Super+S no longer a focus-or-launch binding, but earlier in this file there’s a comment explicitly recommending “Super+G/S/D focus-or-launch bindings” (around lines 183–185). Update that comment to reflect the new intended behavior for Super+S to avoid future confusion.

Copilot uses AI. Check for mistakes.
bind = $mod, C, exec, cursor
bind = $mod, V, exec, code
bind = $mod, P, exec, gtk-launch 1password
Expand Down
Loading