fix(hyprland): fix Slack and Telegram keybindings by shunkakinoki · Pull Request #1293 · shunkakinoki/dotfiles

shunkakinoki · 2026-03-30T06:05:19Z

Summary

Super+S (Slack): Always open new window instead of focus-or-launch
Super+Shift+T (Telegram): Fix modifier from ALT SHIFT to $mod SHIFT, and fix binary name from telegram-desktop to Telegram

Test plan

Verify Super+S opens a new Slack window
Verify Super+Shift+T launches Telegram

🤖 Generated with Claude Code

Summary by cubic

Fix Hyprland keybindings so Slack and Telegram launch reliably.

Bug Fixes
- Super+S now runs slack directly, always opening a new window.
- Super+Shift+T now uses $mod (not ALT) and calls Telegram (correct binary).

^{Written for commit 563bb9a. Summary will update on new commits.}

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

mesa-dot-dev · 2026-03-30T06:05:24Z

You do not have enough credits to review this pull request. Please purchase more credits to continue.

coderabbitai · 2026-03-30T06:05:33Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 68a0600b-271c-483c-8aa8-09f9abab10b9

📥 Commits

Reviewing files that changed from the base of the PR and between c2c4d33 and 563bb9a.

📒 Files selected for processing (1)

config/hyprland/hyprland.conf

📝 Walkthrough

Summary by CodeRabbit

Chores
- Updated application launcher hotkeys in system configuration. Modified keybindings for Telegram and Slack with simplified launch behavior, removing conditional focus logic.

Walkthrough

Modified Hyprland keybindings in the configuration file: changed the Telegram launcher from ALT+SHIFT+T to $mod+SHIFT+T with updated executable label, and simplified the Slack keybinding from conditional focus-or-launch logic to a direct exec command.

Changes

Cohort / File(s)	Summary
Hyprland Configuration `config/hyprland/hyprland.conf`	Updated Telegram keybinding modifier and label ($mod+SHIFT+T → Telegram). Simplified Slack keybinding by removing conditional class-based focus logic and using direct exec command.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

feat(hyprland): add Telegram shortcut #1230: Modifies the Hyprland Telegram keybinding ($mod+SHIFT+T), directly overlapping with the same binding change in this PR.
feat(hyprland): add window resize, split toggle, and macOS-style screenshot keybindings #760: Modifies other Hyprland keybindings in the same configuration file, related at the keybinding configuration level.

Suggested labels

bug

Poem

🐰 The keys they changed, now cleaner flow,
Slack launches swift, no checks to know,
Telegram hops to a new command,
Hotkeys refined across the land! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix(hyprland): fix Slack and Telegram keybindings' directly and accurately summarizes the main changes in the pull request, which are fixes to the keybindings for Slack and Telegram applications.
Description check	✅ Passed	The description provides relevant context for the changeset, detailing the specific fixes to Slack and Telegram keybindings with test plans and rationale for the changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/hyprland-keybindings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

mesa-dot-dev · 2026-03-30T06:05:45Z

Mesa Description

TL;DR

Fixed Hyprland keybindings for Slack and Telegram to ensure correct application launching behavior.

What changed?

Super+S (Slack): Always open new window instead of focus-or-launch
Super+Shift+T (Telegram): Fix modifier from ALT SHIFT to $mod SHIFT, and fix binary name from telegram-desktop to Telegram

^{Description generated by Mesa. Update settings}

gemini-code-assist

Code Review

This pull request updates the application launch hotkeys in the Hyprland configuration, specifically changing the Telegram binding and simplifying the Slack binding by removing the window focus check. Feedback suggests using gtk-launch for both Telegram and Slack to ensure consistency with other bindings and improve robustness by utilizing desktop files.

gemini-code-assist · 2026-03-30T06:06:37Z

 # =============================================================================
 bind = $mod, T, exec, ghostty
-bind = ALT SHIFT, T, exec, telegram-desktop
+bind = $mod SHIFT, T, exec, Telegram


For consistency with how other applications like 1Password (line 233) and Signal (line 234) are launched, consider using gtk-launch. This is generally more robust as it uses the application's .desktop file instead of relying on an executable in the PATH.

The binary name Telegram is also unusual; the executable is typically telegram-desktop. Using gtk-launch with the correct desktop file name (e.g., telegramdesktop) would resolve this ambiguity.

bind = $mod SHIFT, T, exec, gtk-launch telegramdesktop

gemini-code-assist · 2026-03-30T06:06:37Z

+bind = $mod SHIFT, T, exec, Telegram
 bind = $mod, G, exec, hyprctl clients -j | grep -q '"class": "google-chrome"' && hyprctl dispatch focuswindow class:google-chrome || google-chrome-stable
-bind = $mod, S, exec, hyprctl clients -j | grep -q '"class": "Slack"' && hyprctl dispatch focuswindow class:Slack || slack
+bind = $mod, S, exec, slack


For consistency with other application launchers in this file (e.g., lines 233 and 234), consider using gtk-launch to start Slack. This would make the launch method uniform across your application bindings.

bind = $mod, S, exec, gtk-launch slack

cubic-dev-ai

No issues found across 1 file

Copilot

Pull request overview

Updates Hyprland application launch keybindings to adjust how Slack and Telegram are launched from the window manager config.

Changes:

Change Telegram binding to use $mod SHIFT+T and update the executed command.
Simplify Slack binding to always execute Slack rather than focus-or-launch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-30T06:08:12Z

 # =============================================================================
 bind = $mod, T, exec, ghostty
-bind = ALT SHIFT, T, exec, telegram-desktop
+bind = $mod SHIFT, T, exec, Telegram


Telegram is likely not the executable provided by this repo’s installed package set. home-manager/packages/default.nix includes telegram-desktop, and this file previously used telegram-desktop; switching to Telegram may make the keybinding a no-op on fresh setups. Consider using the actual installed binary (telegram-desktop) or a stable desktop entry via gtk-launch if that’s the intended target.

Suggested change

bind = $mod SHIFT, T, exec, Telegram

bind = $mod SHIFT, T, exec, telegram-desktop

Copilot · 2026-03-30T06:08:13Z

+bind = $mod SHIFT, T, exec, Telegram
 bind = $mod, G, exec, hyprctl clients -j | grep -q '"class": "google-chrome"' && hyprctl dispatch focuswindow class:google-chrome || google-chrome-stable
-bind = $mod, S, exec, hyprctl clients -j | grep -q '"class": "Slack"' && hyprctl dispatch focuswindow class:Slack || slack
+bind = $mod, S, exec, slack


PR description says Super+S should “always open a new Slack window”, but this binding now just runs slack without any flag/command to force a new window. If Slack reuses the existing instance (common for Electron apps), this won’t meet the stated behavior; consider invoking Slack with an explicit new-window option or an alternative command that guarantees a new window.

Copilot · 2026-03-30T06:08:13Z

+bind = $mod SHIFT, T, exec, Telegram
 bind = $mod, G, exec, hyprctl clients -j | grep -q '"class": "google-chrome"' && hyprctl dispatch focuswindow class:google-chrome || google-chrome-stable
-bind = $mod, S, exec, hyprctl clients -j | grep -q '"class": "Slack"' && hyprctl dispatch focuswindow class:Slack || slack
+bind = $mod, S, exec, slack


This change makes Super+S no longer a focus-or-launch binding, but earlier in this file there’s a comment explicitly recommending “Super+G/S/D focus-or-launch bindings” (around lines 183–185). Update that comment to reflect the new intended behavior for Super+S to avoid future confusion.

fix(hyprland): fix Slack and Telegram keybindings

563bb9a

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings March 30, 2026 06:05

Copilot started reviewing on behalf of shunkakinoki March 30, 2026 06:06 View session

gemini-code-assist Bot reviewed Mar 30, 2026

View reviewed changes

cubic-dev-ai Bot reviewed Mar 30, 2026

View reviewed changes

Copilot AI reviewed Mar 30, 2026

View reviewed changes

shunkakinoki merged commit 6380fed into main Mar 30, 2026
42 checks passed

shunkakinoki deleted the fix/hyprland-keybindings branch March 30, 2026 08:08

	bind = $mod SHIFT, T, exec, Telegram
	bind = $mod SHIFT, T, exec, telegram-desktop

Conversation

shunkakinoki commented Mar 30, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by cubic

Uh oh!

mesa-dot-dev Bot commented Mar 30, 2026

Uh oh!

coderabbitai Bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

mesa-dot-dev Bot commented Mar 30, 2026

Mesa Description

TL;DR

What changed?

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shunkakinoki commented Mar 30, 2026 •

edited by cubic-dev-ai Bot

Loading

coderabbitai Bot commented Mar 30, 2026 •

edited

Loading