Repository navigation
fix(server): findings get their id from Effect 4.0.4's randomUUIDv4() - #10
Merged
Merged
Conversation
Upstream's Effect 4.0.4 bump made Crypto.randomUUIDv4 a function returning an Effect that can fail with a PlatformError. FindingService still yielded it as a value, so the sync onto v0.0.46-nightly.20261014.3105 and every nightly after it failed typecheck and the report_finding tests. Call it, keep the old no-error behavior with Effect.orDie, and make the test Crypto layer's randomUUIDv4 a function. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shubhdeep128
added a commit
that referenced
this pull request
Oct 15, 2026
…#10) Upstream's Effect 4.0.4 bump made Crypto.randomUUIDv4 a function returning an Effect that can fail with a PlatformError. FindingService still yielded it as a value, so the sync onto v0.0.46-nightly.20261014.3105 and every nightly after it failed typecheck and the report_finding tests. Call it, keep the old no-error behavior with Effect.orDie, and make the test Crypto layer's randomUUIDv4 a function. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
shubhdeep128
added a commit
that referenced
this pull request
Oct 15, 2026
…#10) Upstream's Effect 4.0.4 bump made Crypto.randomUUIDv4 a function returning an Effect that can fail with a PlatformError. FindingService still yielded it as a value, so the sync onto v0.0.46-nightly.20261014.3105 and every nightly after it failed typecheck and the report_finding tests. Call it, keep the old no-error behavior with Effect.orDie, and make the test Crypto layer's randomUUIDv4 a function. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
shubhdeep128
added a commit
that referenced
this pull request
Oct 15, 2026
…#10) Upstream's Effect 4.0.4 bump made Crypto.randomUUIDv4 a function returning an Effect that can fail with a PlatformError. FindingService still yielded it as a value, so the sync onto v0.0.46-nightly.20261014.3105 and every nightly after it failed typecheck and the report_finding tests. Call it, keep the old no-error behavior with Effect.orDie, and make the test Crypto layer's randomUUIDv4 a function. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
shubhdeep128
added a commit
that referenced
this pull request
Oct 16, 2026
…#10) Upstream's Effect 4.0.4 bump made Crypto.randomUUIDv4 a function returning an Effect that can fail with a PlatformError. FindingService still yielded it as a value, so the sync onto v0.0.46-nightly.20261014.3105 and every nightly after it failed typecheck and the report_finding tests. Call it, keep the old no-error behavior with Effect.orDie, and make the test Crypto layer's randomUUIDv4 a function. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
shubhdeep128
added a commit
that referenced
this pull request
Oct 16, 2026
…#10) Upstream's Effect 4.0.4 bump made Crypto.randomUUIDv4 a function returning an Effect that can fail with a PlatformError. FindingService still yielded it as a value, so the sync onto v0.0.46-nightly.20261014.3105 and every nightly after it failed typecheck and the report_finding tests. Call it, keep the old no-error behavior with Effect.orDie, and make the test Crypto layer's randomUUIDv4 a function. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
shubhdeep128
added a commit
that referenced
this pull request
Oct 16, 2026
…#10) Upstream's Effect 4.0.4 bump made Crypto.randomUUIDv4 a function returning an Effect that can fail with a PlatformError. FindingService still yielded it as a value, so the sync onto v0.0.46-nightly.20261014.3105 and every nightly after it failed typecheck and the report_finding tests. Call it, keep the old no-error behavior with Effect.orDie, and make the test Crypto layer's randomUUIDv4 a function. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
shubhdeep128
added a commit
that referenced
this pull request
Oct 16, 2026
…#10) Upstream's Effect 4.0.4 bump made Crypto.randomUUIDv4 a function returning an Effect that can fail with a PlatformError. FindingService still yielded it as a value, so the sync onto v0.0.46-nightly.20261014.3105 and every nightly after it failed typecheck and the report_finding tests. Call it, keep the old no-error behavior with Effect.orDie, and make the test Crypto layer's randomUUIDv4 a function. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream sync has failed on every nightly since
v0.0.46-nightly.20261014.3105. Upstream's Effect 4.0.4 bump (pingdotgg#19213) turnedCrypto.randomUUIDv4into a function that returnsEffect<string, PlatformError>.FindingServicestill yields it as a value, so the apps/server typecheck fails and 4 report_finding tests in the watchers MCP handlers fail.This calls
crypto.randomUUIDv4()and addsEffect.orDie, so creating an id still can't fail, as before. The test Crypto layer'srandomUUIDv4is now a function too. These are the only two uses the fork stack adds. Upstream already updated its own.Fixes the finding
sync:v0.0.46-nightly.20261015.3145:checks.Merge, then sync
forkis still onv0.0.46-nightly.20261013.3053with Effect 4.0.2, whererandomUUIDv4is still a value. This commit only typechecks and runs once the stack sits on a newer nightly. After merging, runnode scripts/fork/sync.ts --pushfrom the fork clone right away instead of waiting for the 6-hour watcher, and don't run the fork fromforkin between.Verification
I replayed the stack plus this commit onto
v0.0.46-nightly.20261015.3145and ran the same checks the sync runs:vp test runon the stack's 15 test files: 15 passed, 102 tests passed, 2 skipped.Without this commit, the same replay fails the same way the finding reported: 5 typecheck errors in
FindingServiceand 4 failed tests inhandlers.test.ts.Fork Actions are off, so this PR has no CI.
Built by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code