Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): don't run AndroidInternetPermissionValidator if no android project exists #995

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Refactors validators to replace scope with canRunInCurrentContext to allow for cases where shorebird doctor is being run within a project but no Android project exists.

Fixes #988

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (890b70a) 100.00% compared to head (8674203) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #995     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          163        83     -80     
  Lines         4136      3079   -1057     
===========================================
- Hits          4136      3079   -1057     
Files Changed Coverage Δ
...ib/src/validators/shorebird_flutter_validator.dart 100.00% <ø> (ø)
...ib/src/validators/shorebird_version_validator.dart 100.00% <ø> (ø)
...s/shorebird_cli/lib/src/validators/validators.dart 100.00% <ø> (ø)
packages/shorebird_cli/lib/src/doctor.dart 100.00% <100.00%> (ø)
...idators/android_internet_permission_validator.dart 100.00% <100.00%> (ø)

... and 80 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel merged commit e722a0b into main Aug 2, 2023
@felangel felangel deleted the bo/android-validator branch August 2, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: shorebird init should not warn about missing Android project when run in a Flutter module
2 participants