Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shorebird init should not warn about missing Android project when run in a Flutter module #988

Closed
eseidel opened this issue Aug 1, 2023 · 0 comments · Fixed by #995
Assignees

Comments

@eseidel
Copy link
Contributor

eseidel commented Aug 1, 2023

In add-to-app example

PS C:\Users\micro\Documents\GitHub\samples\add_to_app\my_flutter_module> shorebird init
✓ Detecting product flavors (8ms)
? How should we refer to this app? (my_flutter_module) my_flutter_module
✓ Shorebird is up-to-date (0.7s)
✓ Flutter install is correct (6.4s)
✗ AndroidManifest.xml files contain INTERNET permission (2ms)
  [✗] No Android project found
1 issue detected.

🐦 Shorebird initialized successfully!

✅ A shorebird app has been created.
✅ A "shorebird.yaml" has been created.
✅ The "pubspec.yaml" has been updated to include "shorebird.yaml" as an asset.

Reference the following commands to get started:

📦 To create a new release use: "shorebird release".
🚀 To push an update use: "shorebird patch".
👀 To preview a release use: "shorebird preview".

For more information about Shorebird, visit https://shorebird.dev
@bryanoltman bryanoltman moved this to Backlog in Adoption Blockers Aug 1, 2023
@bryanoltman bryanoltman changed the title fix: android warning during shorebird init on add_to_app example fix: shorebird init should not warn about missing Android project when run in a Flutter module Aug 1, 2023
@bryanoltman bryanoltman self-assigned this Aug 2, 2023
@bryanoltman bryanoltman moved this from Backlog to In Progress in Adoption Blockers Aug 2, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Adoption Blockers Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
2 participants