Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shorebird_cli): check for existing release before asking user to confirm #660

Merged
merged 1 commit into from
Jun 14, 2023
Merged

fix(shorebird_cli): check for existing release before asking user to confirm #660

merged 1 commit into from
Jun 14, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Moves the check for an existing release version to before we ask the user to confirm.

Fixes #612

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman bryanoltman requested review from eseidel and felangel June 14, 2023 20:40
felangel
felangel approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@bryanoltman bryanoltman enabled auto-merge (squash) June 14, 2023 20:44
@bryanoltman bryanoltman merged commit a11c9be into main Jun 14, 2023
@bryanoltman bryanoltman deleted the bo/check-existing-release-before-confirm branch June 14, 2023 20:45
@bryanoltman bryanoltman mentioned this pull request Jun 14, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@eseidel eseidel Awaiting requested review from eseidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: shorebird release should warn me if before building if version number is taken
2 participants
@bryanoltman @felangel