Prevent tab borders from colliding with containing widget if show_border = false (Fixes #228) #232
Conversation
| // if the notebook property show_border is set to false, the frame directly inside the notebook | ||
| // doesn't exist, so we define the tab margins, the background and backdrop colors here: | ||
|
|
||
| > header { |
There was a problem hiding this comment.
Merge rule > header with rule on line 2049
There was a problem hiding this comment.
I'd rather keep this here, because of the comment above explaining why the last two rules exist.
gtk-3.0/_common.scss
Outdated
| @@ -2043,6 +2043,8 @@ notebook { | |||
| border: 1px solid shade($bg_color, 0.9); | |||
| } | |||
| } | |||
|
|
|||
| &.frame > header { margin-left: 0; } | |||
There was a problem hiding this comment.
Merge rule &.frame > header with rule on line 2039
gtk-3.0/_common.scss
Outdated
| @@ -2043,6 +2043,8 @@ notebook { | |||
| border: 1px solid shade($bg_color, 0.9); | |||
| } | |||
| } | |||
|
|
|||
…der = false (Fixes shimmerproject#228) The core idea of show_border = false is to get rid of the border around the widget and set the margins to zero to visually embed the widget directly inside the containing widget, without introducing additional borders. To facilitate such design choices by applications, Greybird's tabs need to be slightly moved to the right to prevent them from colliding with the containing widget's borders. A screenshot of how this looks in Greybird and other themes is supplied in shimmerproject#228.
| > stack:not(:only-child) { // the :not(:only-child) is for "hidden" notebooks | ||
| background-color: shade($bg_color, 1.05); | ||
| border-width: 1px; | ||
| border-width: 1px 0 0; |
There was a problem hiding this comment.
Properties should be ordered background-color, border-color, border-style, border-width
|
Merged commit 1 of this PR to master. |
|
pavucontrol released a new version back in March, which fixed their spacing issues:
I think the second commit would be good to go now, what do you think @ochosi? |
|
This would also make the workaround in #184 unnecessary. |
|
@soc Sorry for the late reply, had very little time for Greybird recently. In Xubuntu Disco the version of pavucontrol still seems to be too old, which version introduced the margin fix? |
|
Hi Simon, I think Version 4.0 should ship with the fixes:
|
|
I just checked and even the next Ubuntu release will only ship v3.0 (https://packages.ubuntu.com/search?keywords=pavucontrol&searchon=names&suite=eoan§ion=all), so I'm tempted to keep this on hold for now. |
|
Heads up: v4.0 is now in Debian testing, Debian unstable and Ubuntu focal. |
|
@ochosi Can we get this merged? |
|
Ping? |
|
Well, looks like we waited for so long, that not only the application, but the whole PulseAudio thing is approaching obsolescence now. |
The core idea of show_border = false is to get rid of the border around
the widget and set the margins to zero to visually embed the widget
directly inside the containing widget, without introducing additional
borders.
To facilitate such design choices by applications, Greybird's tabs need
to be slightly moved to the right to prevent them from colliding with
the containing widget's borders.
A screenshot of how this looks in Greybird and other themes is supplied
in #228.