-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xfce-terminal has extra pixel border with >1 tab #184
Comments
confirmed with xfce4-terminal (last git revision), and having the same with mate-terminal (1.16) too. |
It appears there's an ancient bug against xfce4-terminal for that :) https://bugzilla.xfce.org/show_bug.cgi?id=3244 |
moreover it does not happen with other themes (like Zukitwo for example), and the old bug is related to gtk2, this one is for gtk3 too |
I have something that seems to work. Adding this to the .config/gtk-3.0/gtk.css fixes the issue: notebook > stack:not(:only-child) {
border: 0;
}
notebook > header.top tabs {
margin-bottom: 0;
}
notebook > header.bottom tabs {
margin-top: 0;
}
notebook > header.left tabs {
margin-right: 0;
}
notebook > header.right tabs {
margin-left: 0;
} It looks like the issue is Greybird setting a 1px border on |
The pixel seems to be back again - please see https://bugzilla.xfce.org/show_bug.cgi?id=15025 |
Actually, the css code above still seems to be working when put to ~/.config/gtk-3.0/gtk.css. How comes it doesn't work in the theme? |
The workaround indeed works (though one has to close all instances of the terminal), as does putting the code in What I don't understand is how my up-to-date Ubuntu Budgie still has the bug. (greybird-gtk-theme at 3.22.9-0ubuntu1). Oh, there it is: |
Indeed, commenting out line 2556 seems to solve the issue. |
Ping @ochosi |
@f2404 If you try to simply remove that line a lot of other applications are broken, e.g. pavucontrol starts to look quite terrible. I'll push a fix specifically for xfce4-terminal. |
@ochosi Thank you! |
Full issue described here (incl screenshot).
https://bugs.launchpad.net/bugs/1683857
The text was updated successfully, but these errors were encountered: