Add missing SolvePnPMethod enum values (AP3P, IPPE, IPPE_SQUARE, SQPNP) - #1898
Conversation
Add the 4 values defined in OpenCV calib3d.hpp that were missing from the SolvePnPMethod enum: AP3P=5, IPPE=6, IPPE_SQUARE=7, SQPNP=8. Fixes #1895 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughFour new members ( ChangesSolvePnPMethod Enum Extension
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes #1895.
The
SolvePnPMethodenum was missing the last 4 values defined in OpenCV'scalib3d.hpp. This PR adds them to match the OpenCV 4.13.0 definition:AP3P = 5IPPE = 6IPPE_SQUARE = 7SQPNP = 8Each value includes an XML doc comment referencing the corresponding paper,
consistent with the existing entries.
Reference: https://github.com/opencv/opencv/blob/4.13.0/modules/calib3d/include/opencv2/calib3d.hpp#L563
Notes
The obsolete
SolvePnPFlagsenum (marked[Obsolete(..., true)], which is acompile-time error) was intentionally left unchanged, since it is no longer usable.
Test
dotnet build src/OpenCvSharp/OpenCvSharp.csproj -c Releasesucceeds with 0 errors(net8.0 / netstandard2.0 / netstandard2.1).
Summary by CodeRabbit