Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpstan doctrine #674

Merged
merged 4 commits into from
Aug 6, 2022
Merged

Add phpstan doctrine #674

merged 4 commits into from
Aug 6, 2022

Conversation

eerison
Copy link
Collaborator

@eerison eerison commented Aug 6, 2022

  • ⚠️ check if the new fields can be added as not null in prod!
  • Test curriculum
  • Test login google

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2022

Codecov Report

Merging #674 (018a30b) into 2.x (d2c1cc5) will decrease coverage by 0.07%.
The diff coverage is 56.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #674      +/-   ##
============================================
- Coverage     62.48%   62.40%   -0.08%     
+ Complexity      294      293       -1     
============================================
  Files            50       50              
  Lines           805      806       +1     
============================================
  Hits            503      503              
- Misses          302      303       +1     
Impacted Files Coverage Δ
src/Controller/Profile/MainController.php 48.27% <0.00%> (-3.58%) ⬇️
src/Controller/SecurityController.php 0.00% <ø> (ø)
src/Entity/Certification.php 100.00% <ø> (ø)
src/Entity/HasUserTrait.php 100.00% <ø> (ø)
src/Repository/UserRepository.php 25.00% <ø> (ø)
src/Security/AuthenticationEntryPoint.php 100.00% <ø> (ø)
src/Security/ThirdPartyAuthenticator.php 12.90% <0.00%> (-0.44%) ⬇️
src/Entity/UserSocialNetworking.php 28.57% <33.33%> (ø)
src/Entity/SocialNetworking.php 25.00% <40.00%> (ø)
src/Entity/User.php 41.75% <50.00%> (+0.45%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2c1cc5...018a30b. Read the comment docs.

@eerison eerison force-pushed the add-phpstan-doctrine branch 3 times, most recently from 7749922 to 99c397c Compare August 6, 2022 18:57
@eerison eerison force-pushed the add-phpstan-doctrine branch 2 times, most recently from 393dfa3 to 031368e Compare August 6, 2022 19:17
@eerison eerison force-pushed the add-phpstan-doctrine branch from 031368e to 018a30b Compare August 6, 2022 19:21
@eerison eerison temporarily deployed to staging_pr August 6, 2022 19:24 Inactive
@eerison eerison merged commit aa3fb87 into 2.x Aug 6, 2022
@eerison eerison deleted the add-phpstan-doctrine branch August 6, 2022 19:37
@eerison eerison temporarily deployed to staging_pr August 6, 2022 19:37 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants