Upgrade phpstan to max level

README.md

@@ -39,7 +39,7 @@ Xdebug is listening on port [10000](.docker/common.env)
 [ci_link]: https://github.com/eerison/myprofile/actions/workflows/continuous_integration.yml?query=workflow%3AContinuous+Integration
 [cd_badge]: https://github.com/eerison/myprofile/actions/workflows/continuous_deploy.yml/badge.svg
 [cd_link]: https://github.com/eerison/myprofile/actions/workflows/continuous_deploy.yml?query=workflow%3AContinuous+Deploy
-[phpstan_badge]: https://img.shields.io/badge/PHPStan-level%207-brightgreen.svg?style=flat
+[phpstan_badge]: https://img.shields.io/badge/PHPStan-level%20max-brightgreen.svg?style=flat
 [phpstan_link]: https://github.com/eerison/myprofile/blob/2.x/phpstan.neon#L2
 [test_badge]: https://codecov.io/gh/eerison/myprofile/branch/2.x/graph/badge.svg?token=ZIW9RTWH1B
 [test_link]: https://codecov.io/gh/eerison/myprofile

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-    level: 7
+    level: max
     paths:
         - src
     checkGenericClassInNonGenericObjectType: false
@@ -8,10 +8,6 @@ parameters:
             - src/EventListener/UpdateCurriculumListener.php
     doctrine:
         objectManagerLoader: tests/object-manager.php
-    symfony:
-        containerXmlPath: var/cache/dev/App_KernelDevDebugContainer.xml
-    scanDirectories:
-        - var/cache/dev/Symfony/Config
     ignoreErrors:
         - '#is never written, only read.#'
         - '#type mapping mismatch\: property can contain App\\Entity\\UserInterface#'

src/Controller/Profile/MainController.php

@@ -9,6 +9,7 @@
 use App\Service\ProfileImageService;
 use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\File\UploadedFile;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
@@ -33,8 +34,13 @@ public function editAction(Request $request, ProfileImageService $profileImageSe
         $form = $this->createForm(ProfileType::class, $user);
         $form->handleRequest($request);
         if ($form->isSubmitted() && $form->isValid()) {
-            $profileImageService->upload($user, $form->get('profile_image')->getData());
-            $backgroundImageService->upload($user, $form->get('background_image')->getData());
+            /** @var ?UploadedFile $profileImage */
+            $profileImage = $form->get('profile_image')->getData();
+            /** @var ?UploadedFile $backgroundImage */
+            $backgroundImage = $form->get('background_image')->getData();
+
+            $profileImageService->upload($user, $profileImage);
+            $backgroundImageService->upload($user, $backgroundImage);
 
             $this->entityManager->persist($user);
             $this->entityManager->flush();

src/Controller/SecurityController.php

@@ -30,6 +30,7 @@ public function authThirdParty(
             return $this->redirectToRoute('profile_edit');
         }
 
+        /** @var ?string $submittedToken */
         $submittedToken = $request->get('token');
 
         if (!$this->isCsrfTokenValid('third-party-login', $submittedToken)) {

src/Entity/Education.php

@@ -5,7 +5,6 @@
 use App\EventListener\UpdateCurriculumListener;
 use App\Repository\EducationRepository;
 use App\ThirdCode\Contracts\EducationInterface;
-use DateTime;
 use DateTimeInterface;
 use Doctrine\DBAL\Types\Types;
 use Doctrine\ORM\Mapping as ORM;
@@ -21,7 +20,7 @@ class Education implements EntityInterface, HasUserInterface, EducationInterface
     #[ORM\Id]
     #[ORM\Column(type: Types::INTEGER)]
     #[ORM\GeneratedValue]
-    protected ?int $id = null;
+    protected int $id;
 
     #[ORM\ManyToOne(targetEntity: User::class, inversedBy: 'educations')]
     #[ORM\JoinColumn(name: 'user_id', nullable: false)]

src/Entity/Experience.php

@@ -5,7 +5,6 @@
 use App\EventListener\UpdateCurriculumListener;
 use App\Repository\ExperienceRepository;
 use App\ThirdCode\Contracts\ExperienceInterface;
-use DateTime;
 use DateTimeInterface;
 use Doctrine\DBAL\Types\Types;
 use Doctrine\ORM\Mapping as ORM;
@@ -21,7 +20,7 @@ class Experience implements ExperienceInterface, EntityInterface, HasUserInterfa
     #[ORM\Id]
     #[ORM\Column(type: Types::INTEGER)]
     #[ORM\GeneratedValue]
-    protected ?int $id = null;
+    protected int $id;
 
     #[ORM\ManyToOne(targetEntity: User::class, inversedBy: 'experiences')]
     #[ORM\JoinColumn(name: 'user_id', nullable: false)]

src/Entity/User.php

@@ -31,7 +31,7 @@ class User implements UserInterface, PasswordAuthenticatedUserInterface, Stringa
     #[ORM\Id]
     #[ORM\Column(type: Types::INTEGER)]
     #[ORM\GeneratedValue]
-    protected ?int $id = null;
+    protected int $id;
 
     #[Assert\Length(max: 200)]
     #[Assert\Email]
@@ -162,7 +162,7 @@ class User implements UserInterface, PasswordAuthenticatedUserInterface, Stringa
 
     private string $backgroundImage;
 
-    private string $website;
+    private ?string $website = null;
 
     public function __construct()
     {
@@ -485,7 +485,7 @@ public function getCreatedAt(): DateTimeInterface
         return $this->createdAt;
     }
 
-    public function getUpdatedAt(): DateTimeInterface
+    public function getUpdatedAt(): ?DateTimeInterface
     {
         return $this->updatedAt;
     }

src/Entity/UserLanguage.php

@@ -29,7 +29,7 @@ class UserLanguage implements EntityInterface, HasUserInterface, SpeakLanguageIn
     #[ORM\Id]
     #[ORM\GeneratedValue]
     #[ORM\Column(type: Types::INTEGER)]
-    private ?int $id = null;
+    private int $id;
 
     #[Assert\Length(max: 50)]
     #[ORM\Column(type: Types::STRING, length: 50)]

src/Entity/UserSocialNetworking.php

@@ -22,7 +22,7 @@ class UserSocialNetworking implements UserSocialNetworkInterface, EntityInterfac
     #[ORM\Id]
     #[ORM\Column(type: Types::INTEGER)]
     #[ORM\GeneratedValue]
-    protected ?int $id = null;
+    protected int $id;
 
     #[ORM\ManyToOne(targetEntity: User::class, inversedBy: 'userSocialNetworks')]
     #[ORM\JoinColumn(name: 'user_id', nullable: false)]

src/Repository/UserRepository.php

@@ -10,7 +10,7 @@
 
 /**
  * @method User[] findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
- * @method User|null findOneBy(array $criteria, ?array $orderBy = null)
+ * @method UserInterface findOneBy(array $criteria, ?array $orderBy = null)
  */
 class UserRepository extends ServiceEntityRepository implements EmailRepositoryInterface
 {

src/Security/ThirdPartyAuthenticator.php

@@ -56,9 +56,11 @@ public function authenticate(Request $request): Passport
 
         /** @var GoogleUser $ownerDetails */
         $ownerDetails = $this->provider->getResourceOwner($apiToken); //@phpstan-ignore-line
+        /** @var string $emailGoogle */
+        $emailGoogle = $ownerDetails->getEmail();
 
         return new SelfValidatingPassport(
-            new UserBadge($ownerDetails->getEmail(), function ($email) use ($ownerDetails) {
+            new UserBadge($emailGoogle, function (string $email) use ($ownerDetails) {
                 // TODO Refactor this method.
                 $user = $this->userRepository->findOneBy(['email' => $email]);
 
@@ -67,7 +69,7 @@ public function authenticate(Request $request): Passport
                     $user
                         ->setFirstName($ownerDetails->getFirstName())
                         ->setLastName($ownerDetails->getLastName())
-                        ->setEmail($ownerDetails->getEmail())
+                        ->setEmail($email)
                         ->setIsVerified(true)
                     ;