Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for bug: location is clobbered when you edit filters, change location, edit filters again #98

Closed
wants to merge 1 commit into from

Conversation

rdoh
Copy link

@rdoh rdoh commented Jun 20, 2020

It fixes the location clobbering problem. I think the params here were just in the wrong order.

@Gnito
Copy link
Collaborator

Gnito commented Jun 26, 2020

Thanks for the PR. I'll check this next week.

This might introduce some new problems since I think the most up-to-date source for values is from the state.
I.e. URL gives initial values, but in some rendering context user input is stored to the state before any "Apply" or "Reset" call is made. Which is to say that URL might say that amenities "towel" is selected, but the user has altered that selection, but not yet applied it (which would redirect user to the same page with updated list of amenities).

@Gnito
Copy link
Collaborator

Gnito commented Jul 1, 2020

@rdoh thanks for the report. I made a bit different fix in sharetribe/ftw-daily#1320 and it's now released also here in release v8.1.0.
Closing this PR.

@Gnito Gnito closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants