Fix: bounds were overwritten by state. #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bug report from FTW-hourly: sharetribe/ftw-hourly#98
Address and bounds are handled outside of MainPanel.
(I.e. TopbarSearchForm && search by moving the map.)
We should always trust
urlQueryParamswith those.How to reproduce:
URL gives initial values for filters, but in some rendering context user input is stored to the state before any "Apply" or "Reset" call is made. (Which is to say that URL might say that amenities "towel" is selected, but the user has altered that selection, but not yet applied it.) We store all the search/query parameters to state in MainPanel.js, but when one of the filters get updated we trusted location search params from the state instead of taking them directly from the URL params.