Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v3.5.1 from upstream #4

Merged
merged 6 commits into from
Sep 17, 2019
Merged

Update v3.5.1 from upstream #4

merged 6 commits into from
Sep 17, 2019

Conversation

Gnito
Copy link
Collaborator

@Gnito Gnito commented Sep 17, 2019

v3.5.1 Changes

  • [add] add orverriding function onAdd and onRemove for CustomOverlayView in
    SearchMapWithGoogleMap to abide to React rules and do not unmountComponentAtNode when a
    component is rendered by React and use appendChild on onAdd instead of draw to
    improve performance.
    #1200
  • [fix] fix CustomOverlayView in SearchMapWithGoogleMap to work with new react-intl version,
    overriding render method to render child object by using createPortal instead of
    unstable_renderSubtreeIntoContainer.
    #1200

tam.vu and others added 6 commits September 16, 2019 14:00
- Adding onAdd and onRemove function to improve performance
- Rewrite current draw() method to compatible with newer react version
[fix bugs] current CustomOverlayView in SearchMapWithGoogleMap does not work with new React version
@Gnito Gnito merged commit 2168508 into master Sep 17, 2019
@Gnito Gnito deleted the update-v3.5.1-from-upstream branch September 17, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant