Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix bugs] current CustomOverlayView in SearchMapWithGoogleMap does not work with new React version #1200

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

rush1506
Copy link
Contributor

  • Adding onAdd and onRemove function to improve performance
  • Rewrite current draw() method to compatible with newer react version

- Adding onAdd and onRemove function to improve performance
- Rewrite current draw() method to compatible with newer react version
@Gnito
Copy link
Contributor

Gnito commented Sep 16, 2019

@rush1506 thanks for the PR. This looks good to me!

I'll merge this tomorrow and make the release.

If you notice this comment before that, could you format the code with Prettier:

  • yarn run format
  • yarn run format-docs

Btw. usually, we make releases in a separate PR, so there's no need to add future release version within feature/bugfix pull-requests.


Anyway, our plan is to remove react-google-maps from FTW at some point since it's essentially a dead dependency.

There's a good alternative mentioned in the issue thread you linked: @react-google-maps/api. However, it would probably be better to avoid these extra dependencies and go to the same direction what we used with Mapbox (i.e. directly play with raw API within our own components, since we just need to use google.maps.OverlayView()).

@Gnito Gnito merged commit e2213a8 into sharetribe:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants