🔥 Remove flaky test #621
Merged
🔥 Remove flaky test #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgibson
force-pushed
the
flaky-test-debug
branch
from
144f14a to
c40ff5d
Compare
|
☝🏼 Looks like the test coverage is still the same even with this test deleted. |
This test is failing pretty consistently in [`sharedb-mongo`][1]. This test has notably had problems [in the past][2], so let's just delete it. [1]: https://github.com/share/sharedb-mongo/actions/runs/6013380406/job/16310733641?pr=151 [2]: #324
alecgibson
force-pushed
the
flaky-test-debug
branch
from
c40ff5d to
0a5c6d2
Compare
ericyhwang
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Sounds fine to me.
The scenario is pretty much covered by the above "doc fetches ops to catch up if it receives a future op" case, and I can't think of a strong reason to separately test multiple subscription ops coming in, especially considering the flakiness rate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is failing pretty consistently in
sharedb-mongo.This test has notably had problems in the past, so let's just delete it.