Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakey test that causes issues with sharedb-mongo in Travis #324

Merged
merged 12 commits into from
Nov 14, 2019

Conversation

nateps
Copy link
Contributor

@nateps nateps commented Nov 14, 2019

Changes

  • Fix flakey test that failed frequently in Travis when run against sharedb-mongo, but didn't fail locally. The tests causes the client to send multiple fetches at the same time in order to get missing ops, and one of the fetches would attempt to getOps after the test done() had been called and the database connection had been closed. Waiting for whenNothingPending() before calling done resolves the flakiness.
  • Add 'error' handlers that pass the error to done(), so that the problematic test can be identified
  • Remove callback existence checks in PubSubMemory that are not needed, because sharedb will never call the methods without a callback (more accurate coverage testing)

@nateps nateps merged commit c210adf into master Nov 14, 2019
@nateps nateps deleted the test-error-visibility branch November 14, 2019 18:58
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.735% when pulling f2b9a40 on test-error-visibility into 66e8866 on master.

alecgibson added a commit that referenced this pull request Aug 29, 2023
This test is failing pretty consistently in [`sharedb-mongo`][1].

This test has notably had problems [in the past][2], so let's just
delete it.

[1]: https://github.com/share/sharedb-mongo/actions/runs/6013380406/job/16310733641?pr=151
[2]: #324
alecgibson added a commit that referenced this pull request Aug 29, 2023
This test is failing pretty consistently in [`sharedb-mongo`][1].

This test has notably had problems [in the past][2], so let's just
delete it.

[1]: https://github.com/share/sharedb-mongo/actions/runs/6013380406/job/16310733641?pr=151
[2]: #324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants