Android/tv-casting-app: Fix for issue in finding handleInternal() on some Android phones #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
sharadb-amazon
changed the title
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
4 similar comments
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
domichae-amazon
approved these changes
May 17, 2023
sharadb-amazon
added a commit
that referenced
this pull request
May 23, 2023
…some Android phones (#165)
sharadb-amazon
added a commit
that referenced
this pull request
May 24, 2023
…some Android phones (#165) (project-chip#26757)
sharadb-amazon
added a commit
that referenced
this pull request
Jun 28, 2023
…some Android phones (#165)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On Android OS 8, we encountered the following errors (not seen before on other phones/versions of Android):
Solution
The error is logged here in the SDK because the call to GetMethodId failed to find the method with the signatures mentioned above: https://github.com/project-chip/connectedhomeip/blob/master/examples/tv-casting-app/android/App/app/src/main/jni/cpp/MatterCallbackHandler-JNI.cpp#L34-L39
This change makes the handleInternal methods public (instead of private) which seems to fix the issue.This change fetches the superclass of the Callback instance passed in by the tv-casting-app code and calls GetMethodId on that Superclass, rather than the Callback class itself. It also marks the handleInternal methods as "protected" instead of "private".
Testing
Verified on the Android 8 test phone where the issue was encountered, by opening the commissioning window