-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android/tv-casting-app: Fix for issue in finding handleInternal() on some Android phones #26757
Merged
sharadb-amazon
merged 1 commit into
project-chip:master
from
sharadb-amazon:droid-handle-20230523
May 24, 2023
Merged
Android/tv-casting-app: Fix for issue in finding handleInternal() on some Android phones #26757
sharadb-amazon
merged 1 commit into
project-chip:master
from
sharadb-amazon:droid-handle-20230523
May 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some Android phones (#165)
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
May 23, 2023 17:07
pullapprove
bot
requested review from
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 23, 2023 17:07
chrisdecenzo
approved these changes
May 23, 2023
PR #26757: Size comparison from ea5f3c0 to b918382 Increases (9 builds for cc32xx, nrfconnect, psoc6, telink)
Decreases (7 builds for bl602, efr32, esp32, psoc6, telink)
Full report (55 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
andy31415
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26756
Problem
On Android OS 8, we encountered the following errors (not seen before on other phones/versions of Android):
Solution
The error is logged here in the SDK because the call to GetMethodId failed to find the method with the signatures mentioned above: https://github.com/project-chip/connectedhomeip/blob/master/examples/tv-casting-app/android/App/app/src/main/jni/cpp/MatterCallbackHandler-JNI.cpp#L34-L39
This change fetches the superclass of the Callback instance passed in by the tv-casting-app code and calls GetMethodId on that Superclass, rather than the Callback class itself. It also marks the handleInternal methods as "protected" instead of "private".
Testing
Verified on the Android 8 test phone where the issue was encountered, by opening the commissioning window