Skip to content

Conversation

@nmnobre
Copy link
Contributor

@nmnobre nmnobre commented Sep 27, 2025

@cticenhour cticenhour self-assigned this Sep 27, 2025
@cticenhour
Copy link
Member

Thanks @nmnobre! I have kicked off testing. Won't be able to get to a review until Monday. That alright?

@moosebuild
Copy link
Collaborator

Job Documentation, step Sync to remote on fc4b5fe wanted to post the following:

View the site here

This comment will be updated on new commits.

@nmnobre
Copy link
Contributor Author

nmnobre commented Sep 28, 2025

Thanks @nmnobre! I have kicked off testing. Won't be able to get to a review until Monday. That alright?

Of course :), it'll take a while until all other apps are updated as well anyway, which in turn means the MOOSE PR won't be merged anytime soon.

@gsgall
Copy link
Collaborator

gsgall commented Sep 29, 2025

Thanks for taking care of this @nmnobre!

I also see that the vars and vals parameters are also deprecated in the MooseParsedFunctionBase object. Should we take care of updating those in this PR or save that for a different one?

@nmnobre
Copy link
Contributor Author

nmnobre commented Sep 29, 2025

Should we take care of updating those in this PR or save that for a different one?

I was thinking maybe I'd do that in a subsequent batch of PRs across MOOSE and all apps again? This one was already a bit more complex than usual because I had to make sure I didn't mess up the indentation for multiline expressions.

@cticenhour cticenhour merged commit d33679d into shannon-lab:devel Oct 7, 2025
3 checks passed
@cticenhour
Copy link
Member

Thanks @nmnobre!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants