Skip to content

Tidy up MooseParsedFunction #31619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open

Tidy up MooseParsedFunction #31619

wants to merge 7 commits into from

Conversation

@nmnobre
Copy link
Member

@nmnobre nmnobre commented Sep 26, 2025

Reason

Remove deprecated functionality and fix flawed logic when determining valid inputs.

Design

Removes deprecated ADParsedFunction alias and value parameter. Simplifies logic to determine if a variable is scalar.

Impact

Might break people's input files.

nmnobre added a commit to nmnobre/moose that referenced this pull request Sep 26, 2025
@nmnobre
Update unit tests to use ParsedFunction's expression param (idaholab#…
26de24e 
…31619)
nmnobre added a commit to nmnobre/moose that referenced this pull request Sep 26, 2025
@nmnobre
Update python tests to use ParsedFunction's expression param (idahola…
8c3bd92 
…b#31619)
@moosebuild
Copy link
Contributor

moosebuild commented Sep 26, 2025 •
edited
Loading

Job Documentation, step Docs: sync website on 5773182 wanted to post the following:

View the site here

This comment will be updated on new commits.

nmnobre added a commit to nmnobre/moose that referenced this pull request Sep 26, 2025
@nmnobre
Update test input files to use ParsedFunction's expression param (ida…
5a29ca8 
…holab#31619)
nmnobre added a commit to nmnobre/moose that referenced this pull request Sep 26, 2025
@nmnobre
Update doc files to use ParsedFunction's expression param (idaholab#3…
8d8bc79 
…1619)
nmnobre added a commit to nmnobre/moose that referenced this pull request Sep 26, 2025
@nmnobre
Update example input param dumps to use ParsedFunction not ADParsedFu…
d46411c 
…nction (idaholab#31619)
nmnobre added a commit to nmnobre/moose that referenced this pull request Sep 26, 2025
@nmnobre
Update unit tests to use ParsedFunction's expression param (idaholab#…
99eb86f 
…31619)
nmnobre added a commit to nmnobre/moose that referenced this pull request Sep 26, 2025
@nmnobre
Update python tests to use ParsedFunction's expression param (idahola…
1035635 
…b#31619)
nmnobre added a commit to nmnobre/moose that referenced this pull request Sep 27, 2025
@nmnobre
Update richards tests to use ParsedFunction's expression param (idaho…
b2950f0 
…lab#31619)
nmnobre added a commit to nmnobre/moose that referenced this pull request Sep 27, 2025
@nmnobre
Update unit tests to use ParsedFunction's expression param (idaholab#…
3c9cf44 
…31619)
nmnobre added a commit to nmnobre/moose that referenced this pull request Sep 27, 2025
@nmnobre
Update python tests to use ParsedFunction's expression param (idahola…
73587a3 
…b#31619)
nmnobre added a commit to nmnobre/moose that referenced this pull request Sep 27, 2025
@nmnobre
Update richards tests to use ParsedFunction's expression param (idaho…
fd7646b 
…lab#31619)
This was referenced Sep 27, 2025
Open
Open
Open
Merged
Merged
Merged
Open
@moosebuild
Copy link
Contributor

moosebuild commented Sep 27, 2025

Job Coverage, step Generate coverage on 5773182 wanted to post the following:

Framework coverage

197299 #31619 577318
Total Total +/- New
Rate 85.90% 85.90% +0.00% 100.00%
Hits 122467 122464 -3 7
Misses 20098 20097 -1 0

Diff coverage report

Full coverage report

Modules coverage

Richards

197299 #31619 577318
Total Total +/- New
Rate 93.41% 93.41% - 100.00%
Hits 3329 3329 - 1
Misses 235 235 - 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@nmnobre nmnobre marked this pull request as ready for review September 27, 2025 15:47
GiudGiud
GiudGiud reviewed Sep 28, 2025
View reviewed changes
Copy link
Contributor

@GiudGiud GiudGiud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal patches are needed for:

  • Marmot
  • Sabertooth
  • SAM
  • Griffin
  • Pronghorn

Reviewed and approving the changes otherwise.
The removal of the deprecation of 'value' is the big change here, which breaks a lot of inputs

@GiudGiud GiudGiud self-assigned this Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GiudGiud GiudGiud GiudGiud left review comments

@lindsayad lindsayad Awaiting requested review from lindsayad lindsayad is a code owner

@joshuahansel joshuahansel Awaiting requested review from joshuahansel joshuahansel is a code owner

@bwspenc bwspenc Awaiting requested review from bwspenc bwspenc is a code owner

@dschwen dschwen Awaiting requested review from dschwen dschwen is a code owner

@jiangwen84 jiangwen84 Awaiting requested review from jiangwen84 jiangwen84 is a code owner

@zachmprince zachmprince Awaiting requested review from zachmprince zachmprince is a code owner

@grmnptr grmnptr Awaiting requested review from grmnptr grmnptr is a code owner

@cticenhour cticenhour Awaiting requested review from cticenhour cticenhour is a code owner

@recuero recuero Awaiting requested review from recuero recuero is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@GiudGiud GiudGiud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nmnobre @moosebuild @GiudGiud