Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completes prior fix 366 for script sanitization #370

Merged
merged 1 commit into from
Apr 5, 2016

Conversation

justin808
Copy link
Member

  • Some cases missed, per: http://stackoverflow.com/a/23983448/1009332
  • Added serverRendering and port to railsContext
  • Only logging attributes client side if tracing to avoid overwhelming
    server logs. On the client, one can optionally toggle expand the
    props. On the server, we stringified, and with a big set of props,
    that could be huge.

This change is Reviewable

@justin808
Copy link
Member Author

@alexfedoseev Take a quick peek at this one as well as #366.

* Some cases missed, per: http://stackoverflow.com/a/23983448/1009332
* Added serverRendering and port to railsContext
* Only logging attributes client side if tracing to avoid overwhelming
  server logs. On the client, one can optionally toggle expand the
  props. On the server, we stringified, and with a big set of props,
  that could be huge.
@justin808 justin808 force-pushed the fix-sanitization-server-console-messages-2 branch from b65ea17 to 9539776 Compare April 5, 2016 07:50
@justin808
Copy link
Member Author

For example, one's code could conditionally log values if on the server, but not on the client. Basically, so long as the rendering comes out the same, React works. If you try to render the value of serverRendering, then React totally breaks.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 87.411% when pulling 9539776 on fix-sanitization-server-console-messages-2 into 7e1c3ce on master.

@alex35mil
Copy link
Member

LGTM 👍

@justin808 justin808 merged commit 13c17d0 into master Apr 5, 2016
@jbhatab jbhatab deleted the fix-sanitization-server-console-messages-2 branch April 23, 2016 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants