Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address failure to sanitize console messages #366

Merged
merged 1 commit into from
Apr 4, 2016
Merged

Address failure to sanitize console messages #366

merged 1 commit into from
Apr 4, 2016

Conversation

justin808
Copy link
Member

  • Only happened with server rendering.
  • Fix is to escape for closing script tag

This change is Reviewable

@justin808
Address failure to sanitize console messages
2cafba2 
* Only happened with server rendering.
* Fix is to escape for closing script tag
@justin808
Copy link
Member Author

@descentintomael, any chance that you can take a quick look at this.

@justin808
Copy link
Member Author

@alexfedoseev @samnang Good enough to just escape the closing </script> tag?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.396% when pulling 2cafba2 on fix-sanitization-server-console-messages into da9d525 on master.

@justin808 justin808 merged commit 791e3cc into master Apr 4, 2016
@justin808
Copy link
Member Author

I'm going to release this one without review. However, I'd like to get this one still reviewed!

@robwise robwise deleted the fix-sanitization-server-console-messages branch April 5, 2016 00:15
@justin808
Copy link
Member Author

Looks like I need to do this: http://stackoverflow.com/a/23983448/1009332

@justin808 justin808 mentioned this pull request Apr 5, 2016
Merged
@justin808 justin808 mentioned this pull request Jul 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justin808 @coveralls