Skip to content

Commit

Permalink
Merge pull request #260 from shakacode/update-ror-5
Browse files Browse the repository at this point in the history
Update to 5.0.0.rc.1 of ReactOnRails
  • Loading branch information
justin808 committed Mar 28, 2016
2 parents ee23eb4 + 03437b5 commit a97fa90
Show file tree
Hide file tree
Showing 6 changed files with 39 additions and 115 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ gem "sdoc", group: :doc
# Use Rails Html Sanitizer for HTML sanitization
gem "rails-html-sanitizer"

gem "react_on_rails", "~> 4.0.0"
gem "react_on_rails", "~> 5.0.0.rc.1"

# See https://github.com/sstephenson/execjs#readme for more supported runtimes
gem "therubyracer"
Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ GEM
rake (10.5.0)
rdoc (4.2.2)
json (~> 1.4)
react_on_rails (4.0.0)
react_on_rails (5.0.0.rc.1)
connection_pool
execjs (~> 2.5)
foreman
Expand Down Expand Up @@ -347,7 +347,7 @@ DEPENDENCIES
rails-html-sanitizer
rails_12factor
rainbow
react_on_rails (~> 4.0.0)
react_on_rails (~> 5.0.0.rc.1)
rspec-rails
rspec-retry
rubocop
Expand Down
3 changes: 2 additions & 1 deletion client/app/bundles/comments/startup/ServerRouterApp.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ import { match, RouterContext } from 'react-router';
import createStore from '../store/commentsStore';
import routes from '../routes/routes';

export default (props, location) => {
export default (props, railsContext) => {
const store = createStore(props);

let error;
let redirectLocation;
let routeProps;
const location = { railsContext };

// See https://github.com/reactjs/react-router/blob/master/docs/guides/ServerRendering.md
match({ routes, location }, (_error, _redirectLocation, _routeProps) => {
Expand Down
136 changes: 30 additions & 106 deletions client/npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"react-addons-pure-render-mixin": "^0.14.7",
"react-bootstrap": "^0.28.3",
"react-dom": "^0.14.7",
"react-on-rails": "^4.0.0",
"react-on-rails": "^5.0.0-rc.1",
"react-redux": "^4.4.0",
"react-router": "^2.0.0",
"react-router-redux": "^4.0.0",
Expand All @@ -81,7 +81,7 @@
"sass-loader": "^3.1.2",
"sass-resources-loader": "1.0.2",
"style-loader": "^0.13.0",
"turbolinks": "0.0.2",
"turbolinks": "^5.0.0-beta3",
"url-loader": "^0.5.7",
"webpack": "^1.12.14"
},
Expand Down
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@
},
"homepage": "https://github.com/shakacode/react-webpack-rails-tutorial",
"dependencies": {
"babel-polyfill": "^6.6.1",
"estraverse": "^4.1.1",
"estraverse-fb": "^1.3.1"
},

This comment has been minimized.

Copy link
@justin808

justin808 Mar 28, 2016

Author Member

This change is unrelated to the React on Rails upgrade.

"devDependencies": {
}
}

0 comments on commit a97fa90

Please sign in to comment.