Skip to content

Commit

Permalink
Merge pull request #259 from shakacode/turbolinks-from-npm
Browse files Browse the repository at this point in the history
Add turbolinks 5 from npm
  • Loading branch information
justin808 committed Mar 27, 2016
2 parents e48b508 + 2854b29 commit ee23eb4
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 11 deletions.
3 changes: 2 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ gem "coffee-rails"

# Turbolinks makes following links in your web application faster.
# Read more: https://github.com/turbolinks/turbolinks
gem 'turbolinks', '>= 5.0.0.beta2'
# Get turbolinks from npm!
# gem 'turbolinks', '>= 5.0.0.beta2'

# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
gem "jbuilder"
Expand Down
4 changes: 0 additions & 4 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -296,9 +296,6 @@ GEM
thread_safe (0.3.5)
tilt (2.0.2)
tins (1.6.0)
turbolinks (5.0.0.beta2)
turbolinks-source
turbolinks-source (5.0.0.beta2)
tzinfo (1.2.2)
thread_safe (~> 0.1)
uglifier (2.7.2)
Expand Down Expand Up @@ -363,7 +360,6 @@ DEPENDENCIES
spring-commands-rspec
sqlite3
therubyracer
turbolinks (>= 5.0.0.beta2)
uglifier
web-console

Expand Down
4 changes: 1 addition & 3 deletions app/assets/javascripts/application_non_webpack.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// All webpack assets in development will be loaded via webpack dev server
// It's important to include them in layout view above this asset
// b/c it exposes jQuery for turbolinks and another non-webpack JS (if any)

//= require turbolinks
// turbolinks comes from npm and is listed in webpack.client.base.config.js

//= require rails_startup
9 changes: 7 additions & 2 deletions client/npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,15 @@
"react-on-rails": "^4.0.0",
"react-redux": "^4.4.0",
"react-router": "^2.0.0",
"redux": "^3.3.1",
"react-router-redux": "^4.0.0",
"redux": "^3.3.1",
"redux-promise": "^0.5.1",
"redux-thunk": "^1.0.3",
"resolve-url-loader": "^1.4.3",
"sass-loader": "^3.1.2",
"sass-resources-loader": "1.0.2",
"style-loader": "^0.13.0",
"turbolinks": "0.0.2",
"url-loader": "^0.5.7",
"webpack": "^1.12.14"
},
Expand All @@ -92,6 +93,7 @@
"eslint": "^2.3.0",
"eslint-config-shakacode": "^3.0.0",
"eslint-plugin-react": "^4.2.0",
"estraverse-fb": "^1.3.1",
"express": "^4.13.4",
"jade": "^1.11.0",
"jscs": "^2.11.0",
Expand Down
2 changes: 2 additions & 0 deletions client/webpack.client.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
'es5-shim/es5-shim',
'es5-shim/es5-sham',
'jquery',
'turbolinks',
],

// This will contain the app entry points defined by webpack.hot.config and webpack.rails.config
Expand Down Expand Up @@ -65,6 +66,7 @@ module.exports = {

{ test: require.resolve('jquery'), loader: 'expose?jQuery' },
{ test: require.resolve('jquery'), loader: 'expose?$' },
{ test: require.resolve('turbolinks'), loader: 'imports?this=>window' },

// Use one of these to serve jQuery for Bootstrap scripts:

Expand Down

0 comments on commit ee23eb4

Please sign in to comment.