Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Install polyfills for Comcast X1 devices #7529

Merged
merged 20 commits into from
Nov 4, 2024
Merged

fix: Install polyfills for Comcast X1 devices #7529

merged 20 commits into from
Nov 4, 2024

Conversation

Iragne
Copy link
Contributor

@Iragne Iragne commented Oct 31, 2024 •
edited by avelad
Loading

Close #7522

@Iragne
Copy link
Contributor Author

Iragne commented Oct 31, 2024

Still testing it

@avelad avelad added type: enhancement New feature or request platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P4 Nice to have / wishful thinking labels Oct 31, 2024
@avelad avelad added this to the v4.12 milestone Oct 31, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented Oct 31, 2024 •
edited
Loading

Incremental code coverage: 87.50%

joeyparrish
joeyparrish reviewed Oct 31, 2024
View reviewed changes
lib/util/platform.js Outdated Show resolved Hide resolved
joeyparrish
joeyparrish reviewed Nov 1, 2024
View reviewed changes
lib/util/platform.js Outdated Show resolved Hide resolved
@Iragne Iragne marked this pull request as ready for review November 4, 2024 08:09
avelad
avelad reviewed Nov 4, 2024
View reviewed changes
lib/util/platform.js Outdated Show resolved Hide resolved
@Iragne Iragne changed the title feat: Support for XOne devices feat: Support for Comcast X1 devices Nov 4, 2024
@avelad avelad requested a review from tykus160 November 4, 2024 09:10
tykus160
tykus160 reviewed Nov 4, 2024
View reviewed changes
externs/comcast.js Outdated Show resolved Hide resolved
@tykus160 tykus160 changed the title feat: Support for Comcast X1 devices fix: Install polyfills for Comcast X1 devices Nov 4, 2024
@avelad avelad merged commit 2b2df4b into shaka-project:main Nov 4, 2024
18 checks passed
@shaka-bot shaka-bot mentioned this pull request Nov 4, 2024
Merged
@tykus160 tykus160 added type: bug Something isn't working correctly and removed type: enhancement New feature or request labels Nov 4, 2024
avelad pushed a commit that referenced this pull request Nov 12, 2024
@Iragne @avelad
fix: Install polyfills for Comcast X1 devices (#7529)
54f9b34 
Close #7522
@shaka-bot shaka-bot mentioned this pull request Nov 12, 2024
Merged
avelad pushed a commit that referenced this pull request Nov 12, 2024
@Iragne @avelad
fix: Install polyfills for Comcast X1 devices (#7529)
30fd3d7 
Close #7522
@shaka-bot shaka-bot mentioned this pull request Nov 12, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Nov 12, 2024
@Iragne @joeyparrish
fix: Install polyfills for Comcast X1 devices (#7529)
5fde258 
Close #7522
@shaka-bot shaka-bot mentioned this pull request Nov 12, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 3, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish left review comments

@avelad avelad avelad approved these changes

@tykus160 tykus160 tykus160 approved these changes

Assignees
No one assigned
Labels
platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.12
Development

Successfully merging this pull request may close these issues.

Xone Support
5 participants
@Iragne @shaka-bot @joeyparrish @avelad @tykus160