Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests failing consistently on Windows #4085

Closed
joeyparrish opened this issue Mar 30, 2022 · 0 comments · Fixed by #4086 or #4009
Closed

Tests failing consistently on Windows #4085

joeyparrish opened this issue Mar 30, 2022 · 0 comments · Fixed by #4086 or #4009
Assignees
@joeyparrish
Labels
component: build system The issue involves the build system of Shaka Player platform: Windows Issues affecting Windows status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.0

Comments

@joeyparrish
Copy link
Member

The tests have been failing consistently on Windows since 6f274cb, where we switch from a deprecated tool to a new one.

In classic Google style, the old tool is deprecated, but the new one isn't quite ready. It generates bogus paths on Windows. The broken dist/deps.js file is why the tests are failing.

This has been filed upstream as google/closure-library#1159 and fixed in google/closure-library#1160, but the fix hasn't been put in an official release yet.
@joeyparrish joeyparrish added type: bug Something isn't working correctly platform: Windows Issues affecting Windows component: tests The issue involves our automated tests (generally; otherwise use a more specific component) labels Mar 30, 2022
@joeyparrish joeyparrish self-assigned this Mar 30, 2022
@joeyparrish joeyparrish added component: build system The issue involves the build system of Shaka Player and removed component: tests The issue involves our automated tests (generally; otherwise use a more specific component) labels Mar 30, 2022
joeyparrish added a commit to joeyparrish/shaka-player that referenced this issue Mar 30, 2022
@joeyparrish
fix: Fix broken deps file generation on Windows
598915c 
This fixes broken deps file generation on Window by upgrading to a
pre-release version of the deps tool.  The upstream issue was filed in
google/closure-library#1159 and fixed in
google/closure-library#1160.

This issue has never affected a release version of Shaka Player, and
was introduced when we switched deps tools in 6f274cb.

Closes shaka-project#4085
@joeyparrish joeyparrish mentioned this issue Mar 30, 2022
Merged
@github-actions github-actions bot added this to the v3.3 milestone Mar 30, 2022
joeyparrish added a commit that referenced this issue Mar 31, 2022
@joeyparrish
fix: Fix broken deps file generation on Windows (#4086)
9660ce8 
This fixes broken deps file generation on Window by upgrading to a
pre-release version of the deps tool.  The upstream issue was filed in
google/closure-library#1159 and fixed in
google/closure-library#1160.

This issue has never affected a release version of Shaka Player, and
was introduced when we switched deps tools in 6f274cb.

Closes #4085
@github-actions github-actions bot mentioned this issue Mar 31, 2022
Merged
@avelad avelad modified the milestones: v3.3, v4.0 May 4, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label May 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
component: build system The issue involves the build system of Shaka Player platform: Windows Issues affecting Windows status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.0
2 participants
@joeyparrish @avelad