-
Notifications
You must be signed in to change notification settings - Fork 16.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📐 PAC: add options for direct and proxied groups #2990
Conversation
- Configuration: geositeDirectGroups + geositeProxiedGroups + geositePreferDirect - PAC: rule generation using these new groups + cleanup
Base After change But there is an issue: after quit Shadowsocks, changing the |
The current behavior is to perform an update of We are targeting v5 for the UI, which will fully support these features. For now, advanced users just have to put up with a few more clicks. 😅 |
This may case user confused... At least have a message bubble popup. Looks need more work here. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me, but someone else must approve.
What's the difference of those two mode? Both modes state that "Chinese domains, as well as non-Chinese companies' Chinese CDNs, are connected to directly." |
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
x
into all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Compiled the code with Visual Studio
Require translation update
Require document update (readme.md, wikipage, etc)
What is the purpose of your pull request?
Description of your pull request and other information
geositeDirectGroups
+geositeProxiedGroups
+geositePreferDirect
geosite
? #2981, attr 类型没有被正确处理 v2fly/domain-list-community#235Notes
geositeDirectGroups
is initialized withcn
andgeolocation-!cn@cn
.geositeProxiedGroups
is initialized withgeolocation-!cn
.geositePreferDirect
is false (default), PAC works in whitelist mode. Exception rules are generated fromgeositeDirectGroups
. Unmatched domains goes through the proxy.geositePreferDirect
is true, PAC works in blacklist mode. Blocking rules are generated fromgeositeProxiedGroups
. Exception rules are generated fromgeositeDirectGroups
. Unmatched domains are connected to directly.