-
Notifications
You must be signed in to change notification settings - Fork 16.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📃 Exclude @cn from PAC proxied list #2982
Conversation
- PAC proxied list only contains domain names from geolocation-!cn without a `cn` attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quick test is passed, base Shadowsocks-4.2.0.40-Release.exe
, the domain like blizzard.cn
etc, has not through the proxy.
But some domains like qualcomm.cn
, dynacw.com.cn
, verisign.com.cn
, microsoft.com
etc, still in the list.
I'm curious about these domains.
Anyway, 👍 Looks good to me, but someone else must approve.
The domains you mentioned don't have the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, for the problems in the third party, I personally think it should be solved only upstream. But when the upstream processing has not yet resulted, I think we can apply some temporary fixes.
See v2fly/domain-list-community#235 (comment). In a nutshell, |
Domain-based methods are all our infrastructure can support right now.
This PR addresses that issue by excluding the
Once again, anyone is more than welcome to work with us to add routing. |
It's actually quite complete for most major service providers.
|
@ziruizhuang Thank you for your insightful comments! I made some improvements in #2990. Please check it out. Feel free to give more feedback! |
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
x
into all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Compiled the code with Visual Studio
Require translation update
Require document update (readme.md, wikipage, etc)
What is the purpose of your pull request?
Description of your pull request and other information
cn
attributegeosite
? #2981.