Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F#333 kuka arm #340

Closed
wants to merge 14 commits into from
Closed

F#333 kuka arm #340

wants to merge 14 commits into from

Conversation

nrontsis
Copy link

@nrontsis nrontsis commented Jul 3, 2015

Working Kuka arm with shadow hand, with MoveIt! integrated! :)

You have to first install my fork of kuka-lwr (branch adaptations_for_SHADOW):
https://github.com/nrontsis/kuka-lwr/tree/adaptations_for_SHADOW

Then you can run the combined robot (including MoveIt!) with:
roslaunch sr_robot_launch right_srhand_lwrarm.launch load_moveit:=true

This solves only partially F#333.

@ugocupcic ugocupcic added the queue label Jul 3, 2015
@nrontsis
Copy link
Author

nrontsis commented Jul 3, 2015

@ugocupcic Sorry for the big delta, it is mostly caused from the newly created MoveIt! package for the shadow+kuka combination.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 07574c0 on nrontsis:F#333_kuka_arm into 0887b0d on shadow-robot:indigo-devel.

@ugocupcic
Copy link
Contributor

@nrontsis could you update the project.rosinstall to use your kuka branch?

@nrontsis
Copy link
Author

nrontsis commented Jul 3, 2015

Sure!

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling da5e3a5 on nrontsis:F#333_kuka_arm into 0887b0d on shadow-robot:indigo-devel.

@@ -17,3 +17,8 @@
local-name: lma_kinematics_plugin
uri: 'https://github.com/shadow-robot/lma_kinematics_plugin'
version: F_ik_with_joint_limits

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will also need the ros_control branch for this to compile
https://github.com/CentroEPiaggio/ros_control/tree/multi-robot-test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To compile, yes, because the code is there, to run, no, because @nrontsis deleted the plugin from the URDF. And also changed the transmissions to sr types. I don't think it is the way to go, if you are not in a hurry I would wait a bit for that.

I will (need to) finish the update on the kuka pkg this weekend, where I plan to discard that dependency as well by adding something similar to what COB people did with the enableJointFilter parameter.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 33ab10d on nrontsis:F#333_kuka_arm into 0887b0d on shadow-robot:indigo-devel.

@nrontsis
Copy link
Author

nrontsis commented Jul 3, 2015

@ugocupcic Is it normal for shippable to fail?

@ugocupcic
Copy link
Contributor

@nrontsis some of the tests are failing (due to a timeout). It has nothing to do with your pull request as far as I can tell. We recently added the tools to this repo, so we have a huge amount of roslint errors etc... which makes the result harder to use.

@nrontsis
Copy link
Author

nrontsis commented Jul 3, 2015

@ugocupcic @carlosjoserg
Following this discussion, I am closing the PR.

I will do a new PR when I have a better implementation of the Kuka+SHADOW combination.

@nrontsis nrontsis closed this Jul 3, 2015
@ugocupcic ugocupcic removed the queue label Jul 3, 2015
@carlosjoserg
Copy link

@nrontsis I recently updated the kuka package, now there is no more dependency on https://github.com/CentroEPiaggio/ros_control/tree/multi-robot-test

There is a pretty definite structure of the arm HW real/sim. Now there is a particular lwr 4+ plugin that uses a very simple gazebo interface (all ros control code is in the abstract class lwr_hw).

The plugin can read a full robot description, since it wukk handle only the joints that belong to the arm instance by name, and then parses only transmissions of those joints (it is the opposite way in the gazebo_ros_control plugin). That's what I meant as a suggestion for the shadow hand plugin, you can write it that it handles only hand joints, and parse the sr transmission types, so both can coexist without problems.

Looking forward to see the shadow ✋ mounted on the kuka.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants