Skip to content

Support the new CoopVec builtins#7108

Merged
jkwak-work merged 4 commits intoshader-slang:masterfrom
jkwak-work:feature/support_coopvec_with_dxc_jun_preview
May 15, 2025
Merged

Support the new CoopVec builtins#7108
jkwak-work merged 4 commits intoshader-slang:masterfrom
jkwak-work:feature/support_coopvec_with_dxc_jun_preview

Conversation

@jkwak-work
Copy link
Copy Markdown
Collaborator

**NOTE: This is a breaking change for users who were using POC variant of DXC.
In order to keep the compatibility, the users will have to use -capability hlsl_coopvec_poc to their command line.

This PR adds a new capability "hlsl_coopvec_poc".

  • When it is used, the HLSL for CoopVec will be emitted for the POC variant of DXC.
  • When it is not used, the HLSL for CoopVec will be emitted for the DXC that officially supports the cooperative vector.

Closes #6758

@jkwak-work jkwak-work self-assigned this May 14, 2025
@jkwak-work jkwak-work requested a review from a team as a code owner May 14, 2025 15:16
@jkwak-work jkwak-work added the pr: breaking change PRs with breaking changes label May 14, 2025
Copy link
Copy Markdown
Contributor

@ArielG-NV ArielG-NV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I have 1 question.

I will let someone else review before approval.

csyonghe
csyonghe previously approved these changes May 15, 2025
Copy link
Copy Markdown
Collaborator

@csyonghe csyonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my understanding is we will get rid of all the poc specific logic in next month or so, when the official DXC support for coop vector is available, right?

@jkwak-work
Copy link
Copy Markdown
Collaborator Author

Looks good, my understanding is we will get rid of all the poc specific logic in next month or so, when the official DXC support for coop vector is available, right?

We could do that and I prefer to do that.
But I am not sure if anybody will yell at us for not supporting it, although the chance is very low.

jkwak-work and others added 3 commits May 14, 2025 18:56
Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
@jkwak-work jkwak-work force-pushed the feature/support_coopvec_with_dxc_jun_preview branch from 471ab62 to c22c52d Compare May 15, 2025 01:57
@jkwak-work jkwak-work disabled auto-merge May 15, 2025 02:57
@jkwak-work jkwak-work merged commit b4d3d30 into shader-slang:master May 15, 2025
17 checks passed
@shader-slang shader-slang deleted a comment from slangbot Jun 3, 2025
@jkwak-work jkwak-work mentioned this pull request Oct 11, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 6, 2025
…opVec (#9213)

This commit removes all POC (Proof of Concept) cooperative vector
support that was deprecated since May 2025. The POC support was added as
a backward compatibility layer for NVIDIA's DXC branch, but the official
Microsoft DXC now has native cooperative vector support.

Changes:
- Remove hlsl_coopvec_poc and hlsl_coopvec_poc_sm_6_9 capability
definitions
- Remove all POC-specific intrinsic implementations from hlsl.meta.slang
- Remove POC code generation logic from emit layer
(slang-emit-c-like.cpp/h)
- Remove POC type emission from HLSL backend
- Update test files to remove POC capability requirements
- Update documentation to remove POC references

The standard cooperative vector implementation remains and is now the
only supported approach for HLSL targets.

Resolves #9209
Related to #7108

---------

Co-authored-by: slangbot <ellieh+slangbot@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: breaking change PRs with breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support CoopVec with a coming DXC April preview release

4 participants