Support the new CoopVec builtins#7108
Merged
jkwak-work merged 4 commits intoshader-slang:masterfrom May 15, 2025
Merged
Conversation
ArielG-NV
reviewed
May 14, 2025
csyonghe
previously approved these changes
May 15, 2025
Collaborator
csyonghe
left a comment
There was a problem hiding this comment.
Looks good, my understanding is we will get rid of all the poc specific logic in next month or so, when the official DXC support for coop vector is available, right?
Collaborator
Author
We could do that and I prefer to do that. |
Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
471ab62 to
c22c52d
Compare
Merged
This was referenced Dec 3, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2025
…opVec (#9213) This commit removes all POC (Proof of Concept) cooperative vector support that was deprecated since May 2025. The POC support was added as a backward compatibility layer for NVIDIA's DXC branch, but the official Microsoft DXC now has native cooperative vector support. Changes: - Remove hlsl_coopvec_poc and hlsl_coopvec_poc_sm_6_9 capability definitions - Remove all POC-specific intrinsic implementations from hlsl.meta.slang - Remove POC code generation logic from emit layer (slang-emit-c-like.cpp/h) - Remove POC type emission from HLSL backend - Update test files to remove POC capability requirements - Update documentation to remove POC references The standard cooperative vector implementation remains and is now the only supported approach for HLSL targets. Resolves #9209 Related to #7108 --------- Co-authored-by: slangbot <ellieh+slangbot@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**NOTE: This is a breaking change for users who were using POC variant of DXC.
In order to keep the compatibility, the users will have to use
-capability hlsl_coopvec_pocto their command line.This PR adds a new capability "hlsl_coopvec_poc".
Closes #6758