Conversation
Collaborator
Author
|
/format |
Contributor
|
🌈 Formatted, please merge the changes from this PR |
szihs
pushed a commit
that referenced
this pull request
Sep 19, 2025
szihs
force-pushed
the
optix_coopvec_matmul
branch
from
2407a47 to
c8c4e13
Compare
Collaborator
Author
|
/format |
Contributor
|
🌈 Formatted, please merge the changes from this PR |
szihs
pushed a commit
that referenced
this pull request
Sep 22, 2025
szihs
pushed a commit
that referenced
this pull request
Sep 22, 2025
szihs
force-pushed
the
optix_coopvec_matmul
branch
from
81e6861 to
14fca92
Compare
Collaborator
Author
|
/format |
Contributor
|
🌈 Formatted, please merge the changes from this PR |
Collaborator
Author
|
@mkeshavaNV can you review this |
jkwak-work
reviewed
Sep 22, 2025
Collaborator
jkwak-work
left a comment
jkwak-work
left a comment
There was a problem hiding this comment.
Do you have a github issue number for this?
Can you mention that in the PR description?
szihs
force-pushed
the
optix_coopvec_matmul
branch
from
d2b4613 to
78cae5e
Compare
szihs
pushed a commit
that referenced
this pull request
Sep 23, 2025
szihs
pushed a commit
that referenced
this pull request
Sep 23, 2025
szihs
added a commit
that referenced
this pull request
Sep 23, 2025
- Add template metaprogramming in prelude for dynamic enum-to-hex conversion - Create SlangToOptixComponentType and SlangToOptixMatrixLayout template specializations - Add OptixCoopVecTraits for automatic vector dimension extraction - Support both with-bias and without-bias OptiX SDK function variants - Fix static assertion placement for multi-capability requirements - Add comprehensive test coverage for StructuredBuffer and ByteAddressBuffer variants - Update CHECK patterns to match new slangOptixCoopVecMatMul wrapper calls Fixes Format code for PR #8489 (#8505) Automated code formatting for #8489 Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> Format code for PR #8489 (#8507) Automated code formatting for #8489 Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> Improve optix-coopvec test patterns to validate actual function calls with arguments Strengthen matmul CHECK pattern to validate function call structure and arguments move static_assert before OptiX parameter transformations to ensure proper constant eval
szihs
force-pushed
the
optix_coopvec_matmul
branch
2 times, most recently
from
6558b7e to
27df82f
Compare
jkwak-work
reviewed
Oct 7, 2025
Collaborator
jkwak-work
left a comment
jkwak-work
left a comment
There was a problem hiding this comment.
I left a few comments.
Collaborator
Author
Updated commit and replied on the query. |
szihs
force-pushed
the
optix_coopvec_matmul
branch
from
de3967b to
53c8716
Compare
Collaborator
Author
|
/format |
Contributor
|
🌈 Formatted, please merge the changes from this PR |
Collaborator
Author
|
ping @jkwak-work for review |
jkwak-work
reviewed
Oct 14, 2025
Collaborator
jkwak-work
left a comment
jkwak-work
left a comment
There was a problem hiding this comment.
Looks way better now, but I think the code should be relocated to slang-emit-cuda.cpp
Collaborator
Author
|
@jkwak-work - updated code for review. |
jkwak-work
reviewed
Oct 15, 2025
Collaborator
Author
|
/format |
Contributor
|
🌈 Formatted, please merge the changes from this PR |
This was
linked to
issues
Oct 16, 2025
jvepsalainen-nv
pushed a commit
to jvepsalainen-nv/slang
that referenced
this pull request
Nov 4, 2025
Fix shader-slang#7404 --------- Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> Co-authored-by: slangbot <ellieh+slangbot@nvidia.com>
juliusikkala
pushed a commit
to juliusikkala/slang
that referenced
this pull request
Nov 12, 2025
Fix shader-slang#7404 --------- Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> Co-authored-by: slangbot <ellieh+slangbot@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7404