Skip to content

Recreate tooltip component and remove rc-tooltip #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 13, 2021
Merged

Recreate tooltip component and remove rc-tooltip #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9e014bc
Update package.json
anitnilay20 Jun 3, 2021
b006153
Update button to a forwarding ref component.
anitnilay20 Jun 3, 2021
e4a46a5
Make Input full width
anitnilay20 Jun 3, 2021
33a9ffe
Update Text Props to inherit HtmlLabel Prop
anitnilay20 Jun 3, 2021
24fe116
Recreate Tooltip component
anitnilay20 Jun 3, 2021
00932f1
Update yarn.lock
anitnilay20 Jun 3, 2021
ae4b24a
Update Calendar to use Updated Tooltip Component
anitnilay20 Jun 3, 2021
58fd6b4
Tests for tooltip.
anitnilay20 Jun 3, 2021
3154c78
Fix failing tests.
anitnilay20 Jun 3, 2021
e249d6d
Fix all failing tests.
anitnilay20 Jun 10, 2021
035276e
Changes related to failing tests
anitnilay20 Jun 10, 2021
2efd969
Fix failing tests.
anitnilay20 Jun 10, 2021
8c027ed
Tests for popover and portal
anitnilay20 Jun 13, 2021
a8ea353
Increase Button test cases.
anitnilay20 Jun 13, 2021
a177914
Fix tests for pagination.
anitnilay20 Jun 13, 2021
a712196
Add tooltip animation.
anitnilay20 Jun 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 61 additions & 39 deletions __tests__/components/AutoComplete/AutoComplete.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ function MultipleAutoComplete({ value, onChange }: { value: string[]; onChange:
}

describe('Single AutoComplete', () => {
it('should render a simple AutoComplete with selected value', () => {
autoComplete('diana', () => ({}));
it('should render a simple AutoComplete with selected value', async () => {
await act(async () => {
autoComplete('diana', () => ({}));
});

const input = document.querySelector('input');
expect(input.value).toBe('diana');
Expand All @@ -62,9 +64,11 @@ describe('Single AutoComplete', () => {
expect(document.querySelector('input').value).toBe('');
});

it('should render a clear button if value is selected', () => {
it('should render a clear button if value is selected', async () => {
let value = 'diana';
autoComplete('diana', (e) => (value = e));
await act(async () => {
autoComplete('diana', (e) => (value = e));
});
expect(document.querySelector('.seudo').innerHTML).toContain(
// Path for cross svg.
'M19 6.41L17.59 5 12 10.59 6.41 5 5 6.41 10.59 12 5 17.59 6.41 19 12 13.41 17.59 19 19 17.59 13.41 12z',
Expand All @@ -77,8 +81,10 @@ describe('Single AutoComplete', () => {
expect(value).toBeNull();
});

it('should not open popup if disabled', () => {
autoComplete('diana', jest.fn, jest.fn, true);
it('should not open popup if disabled', async () => {
await act(async () => {
autoComplete('diana', jest.fn, jest.fn, true);
});

act(() => {
fireEvent.click(document.querySelector('input'));
Expand All @@ -87,18 +93,20 @@ describe('Single AutoComplete', () => {
expect(document.querySelector('.list-item')).toBeNull();
});

it('should fetch data from a promise', () => {
render(
<AutoComplete<string>
data={() => new Promise<string[]>((resolve) => resolve(['bruce', 'diana', 'clark']))}
listDisplayProp={(e) => String(e)}
uniqueIdentifier={(e) => String(e)}
displayValue={(e) => String(e)}
value="diana"
onChange={jest.fn}
searchValue={(e) => e}
/>,
);
it('should fetch data from a promise', async () => {
await act(async () => {
render(
<AutoComplete<string>
data={() => new Promise<string[]>((resolve) => resolve(['bruce', 'diana', 'clark']))}
listDisplayProp={(e) => String(e)}
uniqueIdentifier={(e) => String(e)}
displayValue={(e) => String(e)}
value="diana"
onChange={jest.fn}
searchValue={(e) => e}
/>,
);
});

act(() => {
fireEvent.click(document.querySelector('input'));
Expand All @@ -110,9 +118,11 @@ describe('Single AutoComplete', () => {
.forEach((element, index) => expect(element.innerHTML).toContain(data[index]));
});

it('should update value on select', () => {
it('should update value on select', async () => {
let value = 'diana';
autoComplete(value, (e) => (value = e));
await act(async () => {
autoComplete(value, (e) => (value = e));
});

const input = document.querySelector('input');
act(() => {
Expand All @@ -124,13 +134,15 @@ describe('Single AutoComplete', () => {
expect(value).toBe('bruce');
});

it('should update list on search', () => {
it('should update list on search', async () => {
let search = '';
autoComplete(
'diana',
() => ({}),
(e) => (search = e),
);
await act(async () => {
autoComplete(
'diana',
() => ({}),
(e) => (search = e),
);
});

act(() => {
fireEvent.click(document.querySelector('input'));
Expand All @@ -146,9 +158,11 @@ describe('Single AutoComplete', () => {
expect(document.querySelector('.list-item:nth-child(2)').innerHTML).toContain('clark');
});

it('should navigate list with arrow keys and close popup with escape', () => {
it('should navigate list with arrow keys and close popup with escape', async () => {
let value = 'diana';
autoComplete(value, (e) => (value = e));
await act(async () => {
autoComplete(value, (e) => (value = e));
});

const input = document.querySelector('input');
act(() => {
Expand All @@ -168,12 +182,12 @@ describe('Single AutoComplete', () => {
fireEvent.keyDown(input, { key: 'Enter' });
});
expect(value).toBe('bruce');
expect(document.querySelector('.list-item')).toBeNull();
expect(document.querySelector('.sha-el-tooltip')).toHaveStyle(`opacity: 0;`);

act(() => {
fireEvent.keyDown(input, { key: 'ArrowDown' });
});
expect(document.querySelector('.list-item')).not.toBeNull();
expect(document.querySelector('.sha-el-tooltip')).toHaveStyle(`opacity: 1;`);

act(() => {
fireEvent.keyDown(document.querySelector('input'), { key: 'Enter' });
Expand All @@ -200,15 +214,17 @@ describe('Single AutoComplete', () => {
act(() => {
fireEvent.keyDown(document.querySelector('input'), { key: 'Escape' });
});
expect(document.querySelector('.list-item')).toBeNull();
expect(document.querySelector('.sha-el-tooltip')).toHaveStyle(`opacity: 0;`);
act(() => {
fireEvent.keyDown(document.querySelector('input'), { key: 'ArrowUp' });
});
expect(document.querySelector('.list-item')).not.toBeNull();
});

it('should not have any selected items on list if value is null', () => {
autoComplete(null, () => ({}));
it('should not have any selected items on list if value is null', async () => {
await act(async () => {
autoComplete(null, () => ({}));
});

act(() => {
fireEvent.click(document.querySelector('input'));
Expand All @@ -228,8 +244,10 @@ describe('Single AutoComplete', () => {
`);
});

it('should clear input on search', () => {
autoComplete(null, (e) => expect(e).toBe('bruce'));
it('should clear input on search', async () => {
await act(async () => {
autoComplete(null, (e) => expect(e).toBe('bruce'));
});
act(() => {
fireEvent.click(document.querySelector('input'));
});
Expand All @@ -248,8 +266,10 @@ describe('Single AutoComplete', () => {
});

describe('Multiple AutoComplete', () => {
it('should render autocomplete with multiple values', () => {
render(<MultipleAutoComplete value={['diana', 'clark']} onChange={() => ({})} />);
it('should render autocomplete with multiple values', async () => {
await act(async () => {
render(<MultipleAutoComplete value={['diana', 'clark']} onChange={() => ({})} />);
});

expect(document.querySelector('.seudo').innerHTML).toContain('clark');
expect(document.querySelector('.seudo').innerHTML).toContain('diana');
Expand All @@ -266,9 +286,11 @@ describe('Multiple AutoComplete', () => {
`);
});

it('should update value on select', () => {
it('should update value on select', async () => {
let value = [];
render(<MultipleAutoComplete value={['diana', 'clark']} onChange={(e) => (value = e)} />);
await act(async () => {
render(<MultipleAutoComplete value={['diana', 'clark']} onChange={(e) => (value = e)} />);
});

act(() => {
fireEvent.click(document.querySelector('input'));
Expand Down
36 changes: 36 additions & 0 deletions __tests__/components/Button/Button.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,4 +271,40 @@ describe('Button', () => {
background: rgba(0, 0, 0, 0.2);
`);
});

it('should render a custom anchor component', () => {
const fn = jest.fn();

act(() => {
ReactDOM.render(<Button link component={<a id="hello" />} onClick={fn} />, container);
});

expect(document.getElementById('hello')).toBeDefined();
});

it('should render a custom anchor component which is not clickable while loading', () => {
const fn = jest.fn();

act(() => {
ReactDOM.render(<Button link component={<a id="hello" />} loading onClick={fn} />, container);
});

const button = document.getElementById('hello');

button.click();
expect(fn).toBeCalledTimes(0);
});

it('should render a custom button component which is not clickable while loading', () => {
const fn = jest.fn();

act(() => {
ReactDOM.render(<Button component={<a id="hello" />} loading onClick={fn} />, container);
});

const button = document.getElementById('hello');

button.click();
expect(fn).toBeCalledTimes(0);
});
});
Loading