Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate tooltip component and remove rc-tooltip #97

Merged
merged 16 commits into from
Jun 13, 2021

Conversation

anitnilay20
Copy link
Contributor

PR Details

Description

Please review the releases section of the repository to get the detailed information on changes.

Related Issue

Motivation and Context

  • Reduce dist size

How Has This Been Tested

  • 100% test coverage

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #97 (25ad0db) into master (63a90b3) will increase coverage by 0.32%.
The diff coverage is 95.45%.

❗ Current head 25ad0db differs from pull request most recent head 2866289. Consider uploading reports for the commit 2866289 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   84.23%   84.55%   +0.32%     
==========================================
  Files         140      140              
  Lines        2176     2247      +71     
  Branches      535      562      +27     
==========================================
+ Hits         1833     1900      +67     
- Misses        341      345       +4     
  Partials        2        2              
Impacted Files Coverage Δ
src/components/Calendar/Calendar.tsx 100.00% <ø> (ø)
src/components/Input/style.ts 100.00% <ø> (ø)
src/components/Button/Button.tsx 88.23% <73.33%> (-11.77%) ⬇️
src/components/Text/Text.tsx 100.00% <100.00%> (ø)
src/components/Tooltip/Tooltip.tsx 100.00% <100.00%> (ø)
src/components/Tooltip/style.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a90b3...2866289. Read the comment docs.

@sha-el sha-el locked and limited conversation to collaborators Jun 4, 2021
@prateekshourya29 prateekshourya29 merged commit 129de2d into master Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants