Skip to content

Update mi300x CI docker image to 7.0. #9890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saienduri wants to merge 8 commits into from
Closed

Update mi300x CI docker image to 7.0. #9890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
61ede09
update mi300x docker image to 7.0
saienduri Sep 2, 2025
f3b0901
Merge branch 'main' into dev/saienduri/ci-image-update
hubertlu-tw Sep 4, 2025
ea416a9
Merge branch 'main' into dev/saienduri/ci-image-update
zhyncs Sep 8, 2025
5315bec
Merge branch 'main' into dev/saienduri/ci-image-update
zhyncs Sep 17, 2025
5cd151c
Merge branch 'main' into dev/saienduri/ci-image-update
saienduri Sep 25, 2025
0c51034
Merge branch 'main' into dev/saienduri/ci-image-update
saienduri Oct 6, 2025
8443869
[DO NOT MERGE] this PR is for testing the new capacity (#11271)
deedongala Oct 6, 2025
52407b3
Merge branch 'main' into dev/saienduri/ci-image-update
saienduri Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nightly-test-amd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
if: github.repository == 'sgl-project/sglang' || github.event_name == 'pull_request'
strategy:
matrix:
runner: [linux-mi300-gpu-2, linux-mi325-gpu-2-nightly]
runner: [linux.rocm.gpu.gfx942.2, linux.rocm.gpu.gfx942.2-nightly]
runs-on: ${{matrix.runner}}
steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/amd_ci_start_container.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ fi


# Default base tags (can be overridden by command line arguments)
DEFAULT_MI30X_BASE_TAG="${SGLANG_VERSION}-rocm630-mi30x"
DEFAULT_MI30X_BASE_TAG="${SGLANG_VERSION}-rocm700-mi30x"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this correctly updates the default base tag for MI300X to use rocm700, the hardcoded fallback image for mi30x in the find_latest_image function (lines 106 and 110) is still using rocm630. To ensure CI consistency and prevent it from using an outdated image if the primary one is not found, please update the fallback images to also use rocm700.

For example, line 106 should be updated to:

echo "rocm/sgl-dev:v0.5.0rc0-rocm700-mi30x-20250812"

Copy link

@michael-amd michael-amd Sep 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need wait till a stable rocm700-mi30x, so we can update fallback image. Please hold on the PR for now.

DEFAULT_MI35X_BASE_TAG="${SGLANG_VERSION}-rocm700-mi35x"

# Parse command line arguments
Expand Down
Loading