Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @saienduri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on upgrading the continuous integration environment for MI300x hardware. By updating the underlying ROCm version used in the CI docker image, it ensures that automated tests and builds are performed against the latest compatible software stack, which can improve stability and enable new features for development on these specific GPUs.
Highlights
- CI Docker Image Update: The
mi300xCI Docker image has been updated to use ROCm 7.0. This involves changing the default base tag for MI30X fromrocm630-mi30xtorocm700-mi30xin the CI startup script.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the default MI300X CI docker image to use ROCm 7.0. The change is correct, but I've identified an inconsistency in the script's fallback logic. The hardcoded fallback image for mi30x still points to an older rocm630 image. To ensure CI stability and prevent unexpected behavior, the fallback image should also be updated to rocm700. I've added a specific comment on the changed line to highlight this.
|
|
||
| # Default base tags (can be overridden by command line arguments) | ||
| DEFAULT_MI30X_BASE_TAG="${SGLANG_VERSION}-rocm630-mi30x" | ||
| DEFAULT_MI30X_BASE_TAG="${SGLANG_VERSION}-rocm700-mi30x" |
There was a problem hiding this comment.
While this correctly updates the default base tag for MI300X to use rocm700, the hardcoded fallback image for mi30x in the find_latest_image function (lines 106 and 110) is still using rocm630. To ensure CI consistency and prevent it from using an outdated image if the primary one is not found, please update the fallback images to also use rocm700.
For example, line 106 should be updated to:
echo "rocm/sgl-dev:v0.5.0rc0-rocm700-mi30x-20250812"There was a problem hiding this comment.
Will need wait till a stable rocm700-mi30x, so we can update fallback image. Please hold on the PR for now.
|
Let's wait till this PR (#10032) to be merged, as it will resolve some issues for this PR. |
|
@saienduri do we still need this |
Motivation
Updates the mi300x CI docker image to 7.0.
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist