Repository navigation
[KVCR 3/5] Add opt-in HiCache delivery and placement controls - #45649
Closed
ziqifan617 wants to merge 6 commits into
Closed
ziqifan617 wants to merge 6 commits into
ziqifan617 wants to merge 6 commits into
Conversation
…points Signed-off-by: Ziqi Fan <ziqif@nvidia.com>
… offsets Signed-off-by: Ziqi Fan <ziqif@nvidia.com>
Port the existing HiCache candidate onto upstream eb4b167. Preserve deferred host-pool registration and the rank-local backup capability gate. Source: codex/kvcr-hicache-enablement at ce7a2d19b5 and SGLang sgl-project#43635. Co-authored-by: Lin Hu <linhu@nvidia.com>
Use private anonymous DRAM pools, bounded delivery pipelining, and configurable prefetch query batching. Add optional scheduler thread-switch control and ownership-scoped NUMA allocation with strict registration evidence checks. Keep defaults and workload semantics intact; include CPU contract tests and CLI documentation. Preserve the existing GC-observer removal. No Mooncake implementation or benchmark reports included.
Contributor
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack and review base
Depends on #45647. Logical base:
ziqifan617/kvcr-hicache-storageat705e7a2913d1a6459ef3363f2b8f3e2753a27485.GitHub base is
main, so Files changed is cumulative until ancestors land. Upstream cannot target a base branch in the contributor fork. Exact incremental review: ziqifan617/sglang@705e7a2...142e34cDo not merge before the parent. Rebase/revalidate after it lands. HiCache and linker are independent sibling modes.
Motivation
Keep the earlier HiCache performance work available as a separate review slice, without enlarging initial KVCR enablement or silently changing defaults.
Modifications
The optional KVCR SDK tuning is a separate companion draft; basic HiCache enablement does not depend on it.
Accuracy Tests
Four full ten-prompt runs through Dynamo passed semantic/request/output/native-byte checks. All 160 measured outputs matched the previous reference; 40 measured restores each completed 30,400,315,392 bytes. 713 evidence files were checksum-verified.
Speed Tests and Profiling
Qwen3-32B-FP8, two same-node TP1 B200 replicas, 116K input/four output tokens, identical runtime and Dynamo source on each side. Old SGLang
d037381bf7vs this142e34c04b:Both orders passed the prospective 5% median-regression screen. This is no observed regression for this fixed microbenchmark, not a reproducible 18.6% speedup or an isolated causal claim for this PR. Only two runs per revision; old results varied and the new stack includes an upstream rebase.
Both sides used the same private upstream-aligned runtime (FlashInfer 0.7.2, CUTLASS 4.8.0, DeepGEMM 0.2.3, sgl-kernel 0.4.10). This source-checkout comparison does not certify a new image, balanced-NUMA tuning, cross-host transfer or broader models.
Known merge gate
Upstream has advanced since the tested base. Fresh merge-tree comparison against
a3d00eff58b6c22ea7539f882cc10c537634200bconflicts inpython/sglang/srt/arg_groups/field_order.py. Keep this draft until the ordered-field contract is reconciled and the resulting source revalidated. The published head is the tested source, not an untested rebase.Checklist
Full draft stack
These are upstream draft review slices with logical dependencies, not branches based on upstream staging refs. Dependent Files changed views are cumulative; the incremental comparison above isolates this slice. Do not merge dependent drafts before their ancestors. The original #43635 and existing Dynamo PRs remain unchanged.