Repository navigation
[AMD] Update ROCm AITER pin to 2bb549102 - #44379
Merged
Duyi-Wang merged 7 commits intoOct 15, 2026
Merged
Conversation
[AMD] Update ROCm AITER pin to 4ad9983
Advances all 9 AITER_COMMIT_DEFAULT blocks to the commit validated by AITER Scout sgl-project#170. gfx1250 joins the shared pin and drops its 4 MoE a8w4/a4w4 Gluon reverts: they no longer apply to this tree, and measured 0.852 with them vs 0.859 without on gpt-oss-120B TP1.
kangwangamd
requested review from
Fridge003,
HaiShaw,
ishandhanani,
ispobock,
sogalin and
yctseng0211
as code owners
October 15, 2026 02:45
Duyi-Wang
approved these changes
Oct 15, 2026
bingxche
approved these changes
Oct 15, 2026
sogalin
approved these changes
Oct 15, 2026
5 tasks
This was referenced Oct 15, 2026
1 of 5 tasks
michaelzhang-ai
added a commit
to michaelzhang-ai/sglang
that referenced
this pull request
Oct 15, 2026
…tall sgl-project#44379 dropped the gfx1250 revert block that followed `pip install -r requirements.txt` but kept its trailing backslash, so the next COPY --from=local_src instruction was parsed as pip arguments and the AITER step failed with "no such option: --from" on every ROCm image.
michaelzhang-ai
added a commit
to michaelzhang-ai/sglang
that referenced
this pull request
Oct 15, 2026
ROCm/aiter#6042, sgl-project#5967 and sgl-project#6007 are all ancestors of the AITER pin from sgl-project#44379, so the sgl-project#6042 cherry-pick conflicts in pa_decode_sparse.py and fails the AITER step on gfx942/gfx950. The sgl-project#5967 CSV diff and the group32 other=127 sed (whose file no longer exists) are stale for the same reason.
This was referenced Oct 16, 2026
5 tasks done
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Update the ROCm images from AITER e7d2453f2 to ROCm/aiter@2bb549102. The new pin is 197 upstream commits ahead of the current default and is the candidate validated by AITER Scout #170 (run 38083187535).
Modifications
Update AITER_COMMIT_DEFAULT for all eight gfx942/gfx950 ROCm image flavors: e7d2453f2 → 2bb549102.
Update the gfx1250-rocm1000 stage from its separate pin a6d2b564 to the same 2bb549102, and update the stale comment that described it as a separate pin.
Accuracy Tests
Not run locally; this Docker dependency update requires AMD GPU image/accuracy CI. Docker is not available in the local environment.
Speed Tests and Profiling
Not run as a gate.
Checklist
CI States
Latest PR Test (Base): ✅ Run #38672663900
Latest PR Test (Extra): ❌ Run #38672663747
Latest PR Test (AMD ROCm 10): ❌ Run #38672663772