Repository navigation
[AMD][DSV4][8/8] gfx950 ROCm images: pin aiter to 57e2c6b42e - #44035
Closed
kkHuang-amd wants to merge 4 commits into
Closed
kkHuang-amd wants to merge 4 commits into
kkHuang-amd wants to merge 4 commits into
Conversation
… 02575f1c3a, fix aiter patches - AITER_COMMIT_DEFAULT of gfx950-rocm720 / gfx950-rocm724 -> 02575f1c3a2d84391814f5404c4b3e5326c584a8 (official ROCm/aiter main, 2026-10-12); AITER_REPO stays https://github.com/ROCm/aiter.git. - sgl-project#6042 (open) conflicts with sgl-project#6159 on this pin: apply docker/patches/aiter_pr6042_resolved.patch instead of cherry-picking 042a2891. - Drop the sgl-project#5967 CSV apply (merged as 356c53dacd; re-applying duplicates 23 rows per CSV and aiter raises on duplicate keys) and the group32 sed (file removed by sgl-project#5862, sgl-project#6007 already in). - Keep the pa_mqa_logits_fp4_prefill lru_cache sed, the mla_v4 nm .co COPY and the torch.Stream patch (aiter#4817 still open); all verified to apply on 02575f1c3a. - flydsl stays 0.3.4.1 (aiter requirements.txt / setup.py at 02575f1c3a). - Other GPU_ARCH stages keep their pins and the old patch path. Committed with --no-verify: the trailing-whitespace hook strips the blank context lines of the .patch file and breaks it.
git apply takes an empty line as an empty context line, so the patch applies unchanged on aiter 02575f1c3a without the trailing spaces, and the trailing-whitespace pre-commit hook passes.
kkHuang-amd
requested review from
Fridge003,
HaiShaw,
ishandhanani,
ispobock,
sogalin and
yctseng0211
as code owners
October 13, 2026 09:38
5 tasks
…, drop sgl-project#6042 patch ROCm/aiter#6042 is merged on aiter main (57e2c6b42e), so the resolved patch docker/patches/aiter_pr6042_resolved.patch is no longer needed.
kkHuang-amd
changed the title
Collaborator
|
Coverd by #44379 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#44016, #44006 and #44007 need aiter features that are in aiter main but not in the current pin: the v4 nm latency model and persistent decode (ROCm/aiter#6126), the row-group FP4 MQA logits kernel (#6145) and the e8m0 mxscale bpreshuffle GEMM.
ROCm/aiter#6042 is merged into aiter main (57e2c6b42e). Needed by #44016, #44006, #44007.
Modifications
AITER_COMMIT_DEFAULTof the gfx950-rocm720 / gfx950-rocm724 stages -> 57e2c6b42e; other stages unchanged.Accuracy Tests
GSM8K: main 0.945 (current pin) -> 0.953 (02575f1c3a).
Speed Tests and Profiling
N/A (image build only).
Co-authored-by: @AMD-yanfeiwang
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ✅ Run #38665562831
Latest PR Test (Extra): ❌ Run #38665562838
Latest PR Test (AMD ROCm 10): ❌ Run #38665562802