Repository navigation
[mem_cache] Run mamba models on UnifiedRadixCache when the radix cache is disabled - #42354
Merged
Merged
Conversation
hnyls2002
requested review from
ByronHsu,
Duyi-Wang,
HaiShaw,
ShangmingCai,
Ying1123,
alphabetc1,
hanming-lu,
huangtingwei9988,
hzh0425,
ispobock,
merrymercy,
sogalin,
xiezhq-hermann,
yeahdongcn and
yizhang2077
as code owners
October 3, 2026 06:56
ispobock
approved these changes
Oct 3, 2026
Collaborator
Author
|
/rerun-test test_disaggregation_hybrid_attention.py test_qwen35_gdn_multi_item_scoring.py test_nvidia_nemotron_3_super_bf16_mtp.py test_streaming_session.py test_mamba2_extra_buffer_kl.py |
Contributor
|
Results for 🚀 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--disable-radix-cache, mamba models (GDN, Mamba2, KDA, lightning, incl. MiniCPM SALA and the PD decode side) now useUnifiedRadixCache's disabled mode instead ofChunkCache; the mamba component owns mamba-state release in both modes.MambaComponentrequirespage_size == 1only when the tree caches states; a disabled tree caches none. This also fixes--disable-radix-cache --enable-streaming-sessionon mamba models, which crashed at startup since [Session] Run streaming sessions only onUnifiedRadixCache; reject unverified tree caches #42295.allocation.py) andexact_chunk_fillon the tree actually caching mamba states.MlxAuxiliaryStateComponentreleases in both modes.--enable-flexkv, third-party backends) as not verified, and drop therelease_kv_cachefallback that freed mamba state for them.--disable-radix-cacheas well (it already rejected them with the radix cache on). PreviouslyChunkCachereportedsupports_mamba() == Falseand slipped past the check, but beam forking copies only the KV page mapping (beam_search/fork.py) and never the mamba state, so those beams ran on the wrong recurrent state.Verification (Qwen3.5-4B,
--disable-radix-cache, strict busy mem check + KV page invariants + tree sanity check on): GSM8K 400q default / retract / no-overlap 0.8775 / 0.8875 / 0.8825 (main withChunkCache: 0.875-0.8925), concurrent abort storms, streaming-session kit (default, retract) and abort-leak repro all pass with no leak. Output throughput with checks off matches main within noise (avg 2692 vs 2627 tok/s over 3 alternating pairs).CI States
Latest PR Test (Base): 🚫 Run #37115199321⚠️ Not enabled -- add
Latest PR Test (Extra):
run-ci-extralabel to opt in.Latest PR Test (AMD ROCm 10): ❌ Run #37115199488