Repository navigation
[Session] Run streaming sessions only on UnifiedRadixCache; reject unverified tree caches - #42295
Merged
Merged
Conversation
…reject the rest; lock receipt fix
hnyls2002
requested review from
Ying1123,
alphabetc1,
hanming-lu,
huangtingwei9988,
hzh0425,
ispobock,
merrymercy,
xiezhq-hermann and
yizhang2077
as code owners
October 3, 2026 00:00
…ing and supports_streaming_session
Collaborator
Author
|
/tag-and-rerun-ci |
Collaborator
Author
|
/rerun-test test_streaming_session.py test_streaming_session_swa.py test_streaming_session_extra.py test_streaming_session_swa_extra.py test_session_control.py test_session_latency.py test_registry.py test_streaming_session_unit.py test_minicpm_sparse_cache.py test_prefill_adder.py |
Contributor
|
Results for 🚀 🚀 |
4 of 5 tasks
nvpohanh
added a commit
to peilii/sglang
that referenced
this pull request
Oct 5, 2026
Resolve conflicts with main: - schedule_policy.py: fold main's new max_prefix_len cap into _req_radix_key, and gate the refresh on supports_prefix_sharing() since main removed is_chunk_cache() (sgl-project#42362). - unified_radix_cache.py: keep refresh_device_prefix next to main's supports_prefix_sharing(). - streaming_session.py: take main's version. StreamingSession is no longer a BasePrefixCache wrapper (sgl-project#42295), so the refresh_device_prefix forwarder and its wrapper test are dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--disable-radix-cache --enable-streaming-sessionbuildsUnifiedRadixCachein its disabled mode, the same way host-pool decode retraction already does, instead of wrapping a chunk cache inStreamingSession.PrefillAdder._lock_nodealways hands the acquire's receipt back on release. A disabledUnifiedRadixCachereports itself as a chunk cache, so the oldis_tree_cache()branch released without the receipt and crashed the scheduler on the first admission.--disable-radix-cacheclass intest_streaming_session.py; registry tests for the new routing and the rejection.CI States
Latest PR Test (Base): 🚫 Run #37082323258⚠️ Not enabled -- add
Latest PR Test (Extra):
run-ci-extralabel to opt in.Latest PR Test (AMD ROCm 10): ❌ Run #37082323213